Bug 32872

Summary: Fix cataloguing/value_builder/unimarc_field_4XX.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Description Julian Maurice 2023-02-03 14:03:38 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 14:04:13 UTC
Created attachment 146138 [details] [review]
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:18:16 UTC
Created attachment 146806 [details] [review]
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-30 18:57:05 UTC
Created attachment 149003 [details] [review]
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-30 19:05:20 UTC
How I tested
~~~~~~~~~~~~

1. The plugin is already added to 4XX$t subfields for the default UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for any of the 4XX$t subfields.
4. A form is displayed that lets you search the catalog and choose any record to use for the 4XX$t subfield.
5. This should work the same before and after the patch is applied.

Description
~~~~~~~~~~~

This plugin displays a catalog search form that lets you search for and choose any record in the catalog to use to show the title in any 4XX$t subfield.
Comment 5 Katrin Fischer 2023-04-22 21:14:36 UTC
Created attachment 150094 [details] [review]
Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-24 13:49:43 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-05-10 12:54:21 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.