Bug 33147

Summary: Use template wrapper for breadcrumbs: Catalog part 2
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: andrew.auld, jacob.omara, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2
Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2
Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2

Description Owen Leonard 2023-03-06 13:03:56 UTC
To continue the process started by Bug 32507, this patch will update a few more catalog templates so that they use the new template wrapper for breadcrumbs.

 - catalogue/results.tt
 - catalogue/search-history.tt
 - catalogue/stockrotation.tt
Comment 1 Owen Leonard 2023-03-06 13:26:18 UTC
Created attachment 147783 [details] [review]
Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Catalog search results
- Search history (from the user menu in the header)
- Bibliographic detail page -> Rota (must have StockRotation enabled).
Comment 2 PTFS Europe Sandboxes 2023-03-29 10:39:39 UTC
Created attachment 148900 [details] [review]
Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Catalog search results
- Search history (from the user menu in the header)
- Bibliographic detail page -> Rota (must have StockRotation enabled).

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 22:11:12 UTC
Created attachment 149327 [details] [review]
Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Catalog search results
- Search history (from the user menu in the header)
- Bibliographic detail page -> Rota (must have StockRotation enabled).

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 14:22:51 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:46:12 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.