Bug 33180

Summary: Use template wrapper for tabs: Budgets and Search engine configuration
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: lucas, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on: 32571    
Bug Blocks: 34625    
Attachments: Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

Description Owen Leonard 2023-03-09 15:19:52 UTC
Continuing the work of Bug 32571, I would like to update two templates to use the new WRAPPER for tabs: Administration -> Budgets, and Administration -> Search engine configuration.
Comment 1 Owen Leonard 2023-03-09 15:26:11 UTC
Created attachment 148015 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.
Comment 2 Owen Leonard 2023-03-20 17:16:42 UTC
Created attachment 148422 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.
Comment 3 Matt Blenkinsop 2023-03-29 08:39:22 UTC
Created attachment 148879 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Katrin Fischer 2023-04-08 22:03:26 UTC
Created attachment 149325 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-12 14:44:24 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:37:40 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.