Summary: | 2FA - Form not excluded from autofill | ||
---|---|---|---|
Product: | Koha | Reporter: | Sam S <tech.sam> |
Component: | Staff interface | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
Bug Depends on: | 20476 | ||
Bug Blocks: | |||
Attachments: |
Bug 33253: Turn off autocompletion for 2FA authentication code
Bug 33253: Turn off autocompletion for 2FA authentication code Bug 33253: Turn off autocompletion for 2FA authentication code |
Description
Sam S
2023-03-16 16:52:28 UTC
Created attachment 149725 [details] [review] Bug 33253: Turn off autocompletion for 2FA authentication code The form for entering your authentication code shoudl not suggest previous codes. To test: * Activate TwoFactorAuthentication * Go to your patron account in staff * More > Manage 2-factor authentication * I used "Google authenticator" on my phone, so: * Open app on your phone, add new and scan the QR code * Enter activation code * Log out of staff interface * Log back in, you are now also asked for an authentication code as second step * Look up code in app, enter, get logged in * Log out, log back in - the form now suggests the previous code when you click on it * Apply patch * Reload things (restart_all on ktd) * Verify that you no longer get the suggestion Thx for filing Sam! Maybe you want to test? It should work on the sandboxes too: https://wiki.koha-community.org/wiki/Sandboxes Created attachment 149733 [details] [review] Bug 33253: Turn off autocompletion for 2FA authentication code The form for entering your authentication code shoudl not suggest previous codes. To test: * Activate TwoFactorAuthentication * Go to your patron account in staff * More > Manage 2-factor authentication * I used "Google authenticator" on my phone, so: * Open app on your phone, add new and scan the QR code * Enter activation code * Log out of staff interface * Log back in, you are now also asked for an authentication code as second step * Look up code in app, enter, get logged in * Log out, log back in - the form now suggests the previous code when you click on it * Apply patch * Reload things (restart_all on ktd) * Verify that you no longer get the suggestion Signed-off-by: David Nind <david@davidnind.com> Created attachment 150210 [details] [review] Bug 33253: Turn off autocompletion for 2FA authentication code The form for entering your authentication code shoudl not suggest previous codes. To test: * Activate TwoFactorAuthentication * Go to your patron account in staff * More > Manage 2-factor authentication * I used "Google authenticator" on my phone, so: * Open app on your phone, add new and scan the QR code * Enter activation code * Log out of staff interface * Log back in, you are now also asked for an authentication code as second step * Look up code in app, enter, get logged in * Log out, log back in - the form now suggests the previous code when you click on it * Apply patch * Reload things (restart_all on ktd) * Verify that you no longer get the suggestion Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |