Bug 33365

Summary: Add item type column to call number browser's results table
Product: Koha Reporter: Lucas Gass <lucas>
Component: CatalogingAssignee: Lucas Gass <lucas>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: m.de.rooy, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This adds a new column for the item type to the results list of the cn_browser.pl value builder that can be linked to the subfield for the callnumber.
Version(s) released in:
23.05.00
Attachments: Bug 33365: Add item type column to cn_browser results
Bug 33365: Add item type column to cn_browser results
Bug 33365: Add item type column to cn_browser results
Bug 33365: Add item type column to cn_browser results
Bug 33365: (QA follow-up) Add check on item-level_itypes

Description Lucas Gass 2023-03-29 22:57:11 UTC
Some catalogers would find it handy if the cn_browser plugin included the item type description in the table of cn_browser results.
Comment 1 Lucas Gass 2023-03-29 22:59:07 UTC
Created attachment 148941 [details] [review]
Bug 33365: Add item type column to cn_browser results
Comment 2 Lucas Gass 2023-03-29 22:59:45 UTC
Created attachment 148942 [details] [review]
Bug 33365: Add item type column to cn_browser results

To test:
1. Go to MARC bibliographic framework, pick a framework and go to 952, subfield "o". Turn the cn_browser plugin on.
2. Pick or create an item in that framework, edit that item.
3. TO the right of the 952$o notice the "...". Click that start the call number browser.
4. Notice there is no column for item type.
5. Apply patch, restart_all
6. Notice there is now a column for item type.
Comment 3 David Nind 2023-04-04 17:55:58 UTC
Created attachment 149139 [details] [review]
Bug 33365: Add item type column to cn_browser results

To test:
1. Go to MARC bibliographic framework, pick a framework and go to 952, subfield "o". Turn the cn_browser plugin on.
2. Pick or create an item in that framework, edit that item.
3. TO the right of the 952$o notice the "...". Click that start the call number browser.
4. Notice there is no column for item type.
5. Apply patch, restart_all
6. Notice there is now a column for item type.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-04-22 13:46:33 UTC
Created attachment 150079 [details] [review]
Bug 33365: Add item type column to cn_browser results

To test:
1. Go to MARC bibliographic framework, pick a framework and go to 952, subfield "o". Turn the cn_browser plugin on.
2. Pick or create an item in that framework, edit that item.
3. TO the right of the 952$o notice the "...". Click that start the call number browser.
4. Notice there is no column for item type.
5. Apply patch, restart_all
6. Notice there is now a column for item type.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-04-22 13:46:35 UTC
Created attachment 150080 [details] [review]
Bug 33365: (QA follow-up) Add check on item-level_itypes

With biblio level itemtypes you won't have any on the
item type level, so I feel like it will make sense
to hide the column here like we do in other spots.

To test:
* pref at specific item = itemtype column shows
* pref at biblio level = no itemtype column

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-04-22 13:47:15 UTC
Should we have some check on item-level_itypes here? Just in case... I added a follow-up :)
Comment 7 Tomás Cohen Arazi 2023-05-16 13:18:14 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Pedro Amorim 2023-06-07 11:47:46 UTC
Enhancement. Not pushing to 22.11.x