Bug 33385

Summary: Use template wrapper for breadcrumbs: Patrons part 1
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: andrew.auld, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1
Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1
Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1

Description Owen Leonard 2023-03-31 16:31:40 UTC
To continue the process started by Bug 32507, this patch will update some patron module templates so that they use the new template wrapper for breadcrumbs.

 - members/accountline-details.tt
 - members/apikeys.tt
 - members/boraccount.tt
 - members/deletemem.tt
 - members/discharge.tt
Comment 1 Owen Leonard 2023-03-31 17:01:47 UTC
Created attachment 149048 [details] [review]
Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1

This patch updates several patron templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patron details ->
  - Accounting -> Transactions
    - Transaction details
      - Check the details of a debit and a credit
  - More ->
    - Manage API keys (must have RESTOAuth2ClientCredentials preference
      enabled)
    - Delete (with a patron who has checkouts)
    - Discharge
Comment 2 PTFS Europe Sandboxes 2023-03-31 17:43:36 UTC
Created attachment 149050 [details] [review]
Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1

This patch updates several patron templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patron details ->
  - Accounting -> Transactions
    - Transaction details
      - Check the details of a debit and a credit
  - More ->
    - Manage API keys (must have RESTOAuth2ClientCredentials preference
      enabled)
    - Delete (with a patron who has checkouts)
    - Discharge

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-03-31 17:44:03 UTC
Lovely!
Comment 4 Katrin Fischer 2023-04-08 20:50:30 UTC
Created attachment 149307 [details] [review]
Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1

This patch updates several patron templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patron details ->
  - Accounting -> Transactions
    - Transaction details
      - Check the details of a debit and a credit
  - More ->
    - Manage API keys (must have RESTOAuth2ClientCredentials preference
      enabled)
    - Delete (with a patron who has checkouts)
    - Discharge

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-12 12:28:04 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:26 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.