Bug 33513

Summary: Batch update from report module - no patrons loaded into view
Product: Koha Reporter: Didier Gautheron <didier.gautheron>
Component: ReportsAssignee: Bugs List <koha-bugs>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Bug Depends on: 32368    
Bug Blocks:    
Attachments: Bug 33513: (follow-up) Remove whitespace in batch report lists
Bug 33513: (follow-up) Remove whitespace in batch report lists
Bug 33513: (follow-up) Remove whitespace in batch report lists

Description Didier Gautheron 2023-04-13 05:55:19 UTC
#32368 add spaces in codes list and #27142 is back you can't batch update from reports.
Comment 1 Didier Gautheron 2023-04-13 06:14:20 UTC
Created attachment 149582 [details] [review]
Bug 33513: (follow-up) Remove whitespace in batch report lists

Bug 32368 added whitespaces, remove them.

To test:
 1 - Create a report like:
    SELECT biblionumber FROM biblio
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
 4 - The operations don't find the biblios
 5 - Create a report like:
    SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!
Comment 2 David Nind 2023-04-14 00:33:06 UTC
For me (testing using koha-testing-docker):

1. For the first report (step 1), I had no issues before the patch was applied. I was able to successfully use the batch record modification, batch record deletion, and add to list options. Things worked the same after the patch was applied.

2. For the second report (step 5), I did have issues that the patch fixed. Before the patch was applied, there was a warning when the batch patron modification was used: "Warning, the following card numbers were not found:". The odd thing about this is that card number 1 was able to be modified, and was the only one there wasn't a warning about. After the patch was applied, all were able to be modified.

On the basis that it does fix things, just not exactly as set out in the test plan, I will sign off.

Maybe you could comment on why I got different results than the test plan, which may help the QA Team?

Testing notes (using KTD):

1. To find the batch operations after running a report, look under 'Total number of results' - there should be buttons saying: 'Batch operations with 20 visible records', 'Rows per page: 20', and 'Hide data menus'. Clicking on the 'Batch operations...' gives you some options, and clicking on 'Rows per page: ...' lets you change the number of results displayed. (It took me a while to find this, even though it was staring me in the face! 8-))
Comment 3 David Nind 2023-04-14 00:33:57 UTC
Created attachment 149628 [details] [review]
Bug 33513: (follow-up) Remove whitespace in batch report lists

Bug 32368 added whitespaces, remove them.

To test:
 1 - Create a report like:
    SELECT biblionumber FROM biblio
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
 4 - The operations don't find the biblios
 5 - Create a report like:
    SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-04-15 23:03:17 UTC
Created attachment 149718 [details] [review]
Bug 33513: (follow-up) Remove whitespace in batch report lists

Bug 32368 added whitespaces, remove them.

To test:
 1 - Create a report like:
    SELECT biblionumber FROM biblio
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
 4 - The operations don't find the biblios
 5 - Create a report like:
    SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-05-09 13:51:46 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-05-15 10:36:32 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-06-15 16:43:35 UTC
Missing dependencies for 22.05.x, no backport.