Bug 33599

Summary: Use template wrapper for breadcrumbs: Various
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: david, lucas, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33599: Use template wrapper for breadcrumbs: Various
Bug 33599: Use template wrapper for breadcrumbs: Various
Bug 33599: Use template wrapper for breadcrumbs: Various
Bug 33599: Use template wrapper for breadcrumbs: Various

Description Owen Leonard 2023-04-24 11:27:25 UTC Comment hidden (obsolete)
Comment 1 Owen Leonard 2023-04-24 14:45:53 UTC
To continue the process started by Bug 32507, this patch will update various templates so that they use the new template wrapper for breadcrumbs.

- ill/ill-requests.tt
- reserve/request.tt
- reviews/reviewswaiting.tt
- suggestion/suggestion.tt
- virtualshelves/shelves.tt
Comment 2 Owen Leonard 2023-04-24 18:29:39 UTC
Created attachment 150170 [details] [review]
Bug 33599: Use template wrapper for breadcrumbs: Various

This patch updates various templates so that they use the new WRAPPER
for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- ILL requests
  - New ill request
  - Manage ill request
- Bibliographic record ->
  - Place hold
  - Place multiple holds
- Tools ->
  - Comments awaiting moderation
  - Approved comments
- Suggestions
  - New suggestion
  - View suggestion
  - Edit suggestion
- Lists
  - Public Lists
  - Private lists
  - New list
  - Edit list
  - Transfer list
  - View list contents
Comment 3 David Nind 2023-04-24 22:43:07 UTC
I have Failed QA because of a change for suggestions:

1. After the patch is applied, when you view a suggestion the breadcrumb is Home > Acqusitions > Show suggestion #X. Before the patch was applied, it was Home > Acqusitions > Suggestions > Show suggestion #X.


In addition, I noted these things - the patch reflects the behaviour before it was applied:

1. ILL requests:
   - For most of the options for a request the breadcrumb is Home > ILL request (Edit request, Confirm request, Place request with partner, Delete request, Edit item metadata)
   - Should this be Home > ILL requests > Request XXXX > Action?

2. Tools > Comments:
   - For the tab 'Comments awaiting moderation', the 'Comments' sidebar menu option is highlighted.
   - For the tab 'Approved comments' it isn't.

3. Suggestions:
   - Sidebar menu option 'Suggestions' not highlighted sometimes when you change between the suggestion status tabs (I think this is when you select a suggestion(s) and then mark select as and choose an option where there is not a tab).

Testing notes (using KTD):

1. Setting up the ILL FreeForm backend:
   - mkdir Koha/Illbackends
   - change to Illbackends directory
   - git clone https://github.com/PTFS-Europe/koha-ill-freeform.git
   - rename directory: mv koha-ill-freeform to FreeForm
   - edit /etc/koha/sites/kohadev/koha-conf.xml
   - in the <interlibrary_loans> section change:
     . backend_directory to: <backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory>
     . partner_code to: <partner_code>IL</partner_code>
   - flush_memcached and restart_all
   - enable ILLModule system preference
   - check that there are no ILL warnings under About > System information
   - check that you can create a request: ILL requests > New ILL request
Comment 4 Owen Leonard 2023-04-25 11:13:18 UTC
Created attachment 150186 [details] [review]
Bug 33599: Use template wrapper for breadcrumbs: Various

This patch updates various templates so that they use the new WRAPPER
for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- ILL requests
  - New ill request
  - Manage ill request
- Bibliographic record ->
  - Place hold
  - Place multiple holds
- Tools ->
  - Comments awaiting moderation
  - Approved comments
- Suggestions
  - New suggestion
  - View suggestion
  - Edit suggestion
- Lists
  - Public Lists
  - Private lists
  - New list
  - Edit list
  - Transfer list
  - View list contents
Comment 5 David Nind 2023-04-25 12:14:19 UTC
Created attachment 150192 [details] [review]
Bug 33599: Use template wrapper for breadcrumbs: Various

This patch updates various templates so that they use the new WRAPPER
for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- ILL requests
  - New ill request
  - Manage ill request
- Bibliographic record ->
  - Place hold
  - Place multiple holds
- Tools ->
  - Comments awaiting moderation
  - Approved comments
- Suggestions
  - New suggestion
  - View suggestion
  - Edit suggestion
- Lists
  - Public Lists
  - Private lists
  - New list
  - Edit list
  - Transfer list
  - View list contents

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Lucas Gass 2023-04-25 19:50:48 UTC
Owen, excuse me for not knowing but are these ILL pages being handled in a separate bug?

-Edit request
-Confirm request 
-Place request with partner libraries
-Edit item metadata
Comment 7 Owen Leonard 2023-04-26 15:44:30 UTC
(In reply to Lucas Gass from comment #6)
> -Edit request
> -Confirm request 
> -Place request with partner libraries
> -Edit item metadata

These are all handled in the same template, but the existing breadcrumbs (in master) don't cover those cases. This could be addressed in another patch
Comment 8 Tomás Cohen Arazi 2023-05-16 18:00:02 UTC
Created attachment 151316 [details] [review]
Bug 33599: Use template wrapper for breadcrumbs: Various

This patch updates various templates so that they use the new WRAPPER
for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- ILL requests
  - New ill request
  - Manage ill request
- Bibliographic record ->
  - Place hold
  - Place multiple holds
- Tools ->
  - Comments awaiting moderation
  - Approved comments
- Suggestions
  - New suggestion
  - View suggestion
  - Edit suggestion
- Lists
  - Public Lists
  - Private lists
  - New list
  - Edit list
  - Transfer list
  - View list contents

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Tomás Cohen Arazi 2023-05-16 18:19:44 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-06-08 16:08:37 UTC
Nice work everyone!

Pushed to stable for 22.11.x