Bug 33607

Summary: Show framework on record details page
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Staff interfaceAssignee: Nick Clemens (kidclamp) <nick>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, jonathan.druart, lucas, matt.blenkinsop, philip.orr
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Philip Orr Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/834
Text to go in the release notes:
With this patch the MARC framework shows at the end of the bibliographic description on the catalog detail page in the staff interface.
Version(s) released in:
23.05.00
Attachments: Bug 33607: Add framework display to staff details page
Bug 33607: Add framework display to staff details page
Bug 33607: (follow-up) Handle default framework
Bug 33607: Add framework display to staff details page
Bug 33607: (follow-up) Handle default framework
[ALTERNATE PATCH] Bug 33607: Handle default framework
Bug 33607: Add framework display to staff details page
Bug 33607: Handle default framework

Description Nick Clemens (kidclamp) 2023-04-25 13:27:11 UTC
Currently you can only see the framework for a record by editing the record. It would be useful to make this visible when viewing a record in the staff client
Comment 1 Nick Clemens (kidclamp) 2023-04-25 15:21:30 UTC
Created attachment 150212 [details] [review]
Bug 33607: Add framework display to staff details page

This patch adds a Frameworks pluing to allow fetching the framework text
and displays this on the intranet details page

To test:
1 - Apply patch
2 - View a record details page in staff
3 - Confirm you see the framework name
4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t
Comment 2 Lucas Gass 2023-04-25 20:18:22 UTC
This is handy! I think the tests for Frameworks.t need to have permissions changed to -rwxrwxr-x .

Also, is this something to be concerned about?

 FAIL	Koha/Template/Plugin/Frameworks.pm
   FAIL	  pod coverage
		POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666
Comment 3 Nick Clemens (kidclamp) 2023-04-26 11:18:34 UTC
Created attachment 150238 [details] [review]
Bug 33607: Add framework display to staff details page

This patch adds a Frameworks pluing to allow fetching the framework text
and displays this on the intranet details page

To test:
1 - Apply patch
2 - View a record details page in staff
3 - Confirm you see the framework name
4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t
Comment 4 Lucas Gass 2023-05-02 22:48:38 UTC
Hey Nick,

Can this take into account the default framework, which does not have a framworkcode?
Comment 5 Nick Clemens (kidclamp) 2023-05-03 11:30:23 UTC
Created attachment 150574 [details] [review]
Bug 33607: (follow-up) Handle default framework
Comment 6 David Nind 2023-05-03 11:56:43 UTC
Created attachment 150578 [details] [review]
Bug 33607: Add framework display to staff details page

This patch adds a Frameworks pluing to allow fetching the framework text
and displays this on the intranet details page

To test:
1 - Apply patch
2 - View a record details page in staff
3 - Confirm you see the framework name
4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-05-03 11:56:46 UTC
Created attachment 150579 [details] [review]
Bug 33607: (follow-up) Handle default framework

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Jonathan Druart 2023-05-09 10:05:31 UTC
Created attachment 150836 [details] [review]
[ALTERNATE PATCH] Bug 33607: Handle default framework
Comment 9 Jonathan Druart 2023-05-09 10:05:50 UTC
What about this patch, Nick?
Comment 10 Nick Clemens (kidclamp) 2023-05-09 10:54:12 UTC
(In reply to Jonathan Druart from comment #9)
> What about this patch, Nick?

Yes, that's better, I need to learn translation tools  :-)
Comment 11 Jonathan Druart 2023-05-09 12:03:24 UTC
Created attachment 150860 [details] [review]
Bug 33607: Add framework display to staff details page

This patch adds a Frameworks pluing to allow fetching the framework text
and displays this on the intranet details page

To test:
1 - Apply patch
2 - View a record details page in staff
3 - Confirm you see the framework name
4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jonathan Druart 2023-05-09 12:03:27 UTC
Created attachment 150861 [details] [review]
Bug 33607: Handle default framework

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Tomás Cohen Arazi 2023-05-16 18:19:48 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 14 Matt Blenkinsop 2023-06-08 16:09:27 UTC
Enhancement - not backporting to 22.11.x