Bug 33673

Summary: Global system preferences - change to just system preferences
Product: Koha Reporter: David Nind <david>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: caroline.cyr-la-rose, gmcharlt, magnus, matt.blenkinsop
Version: MainKeywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/687
Text to go in the release notes:
Version(s) released in:
23.05.00
Attachments: Bug 33673: Change "global system preferences" to "system preferences"
Bug 33673: Change "global system preferences" to "system preferences"
Bug 33673: Change "global system preferences" to "system preferences"

Description David Nind 2023-05-04 00:49:20 UTC
Day-to-day, we normally just refer to "system preferences" rather than "global system preferences".

I don't think there is any clear distinction between "Global system preferences" and "System preferences", or any need to have the "Global". 

This would mean changing Administration > Global system preferences to just "System preferences".
Comment 1 David Nind 2023-05-04 20:35:00 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-05-04 20:36:11 UTC
This is the first time I've done a database update - hopefully I got it right!

Also, I'm not sure anyone will agree with me about changing this - comments welcome!
Comment 3 Magnus Enger 2023-05-05 11:47:05 UTC
Created attachment 150733 [details] [review]
Bug 33673: Change "global system preferences" to "system preferences"

The Koha Community normally refers to "global system preferences"
as just "system preferences".

This updates the staff interface and other occurences to refelect
this, including:
- Administration > Global system preferences and the description
- Patrons > [a patron] > More > Set permissions > Manage Koha
  system settings > Manage global system preferences
  (manage_sysprefs)
- The installer files and the database (permissions table)

Test plan:
1. Note that in the staff interface "Global system preferences"
   is dispalyed in two places:
   1.1 Administration: Go to Administration. There is a section
       called "Global system preferences" with a description
       and a search box.
   1.2 User permissions: View the details for a patron > More >
       Set permissions > expand 'Manage Koha system settings' >
       scroll down to 'Manage global system preferences
       (manage_sysprefs)'
2. Apply the patch.
3. Update the database.
4. Revisit the pages in step 1 - these should now show as
   "System prefereneces" or "system preferences" as appropriate.
5. Sign off!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
I agree with this change, consistency is good. As far as I can see
this patch cathes all the occurrences of "global".
Comment 4 Magnus Enger 2023-05-05 11:47:59 UTC
(In reply to David Nind from comment #2)
> This is the first time I've done a database update - hopefully I got it
> right!

Works nicely as far as I can see. Well done! :-)
Comment 5 David Nind 2023-05-05 17:45:12 UTC
(In reply to Magnus Enger from comment #4)
> (In reply to David Nind from comment #2)
> > This is the first time I've done a database update - hopefully I got it
> > right!
> 
> Works nicely as far as I can see. Well done! :-)

Thanks Magnus!
Comment 6 Katrin Fischer 2023-05-08 22:10:36 UTC
Created attachment 150816 [details] [review]
Bug 33673: Change "global system preferences" to "system preferences"

The Koha Community normally refers to "global system preferences"
as just "system preferences".

This updates the staff interface and other occurences to refelect
this, including:
- Administration > Global system preferences and the description
- Patrons > [a patron] > More > Set permissions > Manage Koha
  system settings > Manage global system preferences
  (manage_sysprefs)
- The installer files and the database (permissions table)

Test plan:
1. Note that in the staff interface "Global system preferences"
   is dispalyed in two places:
   1.1 Administration: Go to Administration. There is a section
       called "Global system preferences" with a description
       and a search box.
   1.2 User permissions: View the details for a patron > More >
       Set permissions > expand 'Manage Koha system settings' >
       scroll down to 'Manage global system preferences
       (manage_sysprefs)'
2. Apply the patch.
3. Update the database.
4. Revisit the pages in step 1 - these should now show as
   "System prefereneces" or "system preferences" as appropriate.
5. Sign off!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
I agree with this change, consistency is good. As far as I can see
this patch cathes all the occurrences of "global".
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-05-09 13:52:05 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-05-15 10:15:35 UTC
Enhancement - not backporting to 22.11.x