Bug 33686

Summary: Update plugin unimarc_field_100.pl 'Script of title' with 2022 values
Product: Koha Reporter: Thibaud Guillot <thibaud.guillot>
Component: CatalogingAssignee: Thibaud Guillot <thibaud.guillot>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy, pierre.genty
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Attachments: Bug 33686: Update plugin unimarc_field_110.pl with 2022 values
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values
Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info
Bug 33686: Correction of existing terms related to 'Script of title'
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values
Bug 33686: Correction of existing terms related to 'Script of title'
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values
Bug 33686: Correction of existing terms related to 'Script of title'
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values
Bug 33686: Correction of existing terms related to 'Script of title'
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values
Bug 33686: Correction of existing terms related to 'Script of title'

Description Thibaud Guillot 2023-05-05 11:00:23 UTC
Hello all,

Update of the data with the values introduced in 2022 concerning unimarc_field_110.pl

Was missing : 

- ib : birman
- ic : khmer
- jb : bengali
- jc : gujurati
- jd : gurmukhi
- je : odia (oriya)
- lb : kannada (kannara)
- lc : malayalam
- ld : singhalais (cinghalais)
- le : télougou
- na : éthiopien (guèze)
Comment 1 Thibaud Guillot 2023-05-05 11:03:44 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-05-06 23:47:35 UTC
Created attachment 150790 [details] [review]
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

Was missing :

- ib : birman
- ic : khmer
- jb : bengali
- jc : gujurati
- jd : gurmukhi
- je : odia (oriya)
- lb : kannada (kannara)
- lc : malayalam
- ld : singhalais (cinghalais)
- le : télougou
- na : éthiopien (guèze)

Sponsored by BibLibre

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-05-07 00:01:33 UTC
I've signed off, as this adds the new values in the 2022 UNIMARC update.

However, I do have a question: should the script of title name values match exactly with the UNIMARC definitions (see references)?

For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), but in Koha it is shown as eg Dongba (Naxi).

If they should, I'm happy to create a bug for that.

References:
1. UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-updates/
2. Tag 100 values (see page 8 for 'Script of title') https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Testing notes (using KTD):
1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc
2. Edit a record and view the values for tag 100 and the 'Script of title' dropdown list.
3. Codes and names for values being added by this bug are not listed.
4. Apply the patch.
5. Restart everything (flush_memcached, restart_all, clear browser cache).
6. Repeat step 2.
7. New codes and values are now lsited.
Comment 4 Thibaud Guillot 2023-05-10 07:02:30 UTC Comment hidden (obsolete)
Comment 5 Thibaud Guillot 2023-05-10 08:08:47 UTC Comment hidden (obsolete)
Comment 6 Thibaud Guillot 2023-05-10 08:09:08 UTC Comment hidden (obsolete)
Comment 7 Thibaud Guillot 2023-05-10 08:10:21 UTC Comment hidden (obsolete)
Comment 8 Thibaud Guillot 2023-05-10 08:10:23 UTC Comment hidden (obsolete)
Comment 9 Thibaud Guillot 2023-05-10 08:15:06 UTC
Created attachment 150937 [details] [review]
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf


 Current status: Needs Signoff
Comment 10 Thibaud Guillot 2023-05-10 08:15:09 UTC
Created attachment 150938 [details] [review]
Bug 33686: Correction of existing terms related to 'Script of title'

According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
Comment 11 Thibaud Guillot 2023-05-10 08:18:58 UTC
(In reply to David Nind from comment #3)
> I've signed off, as this adds the new values in the 2022 UNIMARC update.
> 
> However, I do have a question: should the script of title name values match
> exactly with the UNIMARC definitions (see references)?
> 
> For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba),
> but in Koha it is shown as eg Dongba (Naxi).
> 
> If they should, I'm happy to create a bug for that.
> 
> References:
> 1. UNIMARC Bibliographic (3rd ed.) Updates
> https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-
> updates/
> 2. Tag 100 values (see page 8 for 'Script of title')
> https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
> 
> Testing notes (using KTD):
> 1. Before starting KTD, edit your .env file to change
> KOHA_MARC_FLAVOUR=unimarc
> 2. Edit a record and view the values for tag 100 and the 'Script of title'
> dropdown list.
> 3. Codes and names for values being added by this bug are not listed.
> 4. Apply the patch.
> 5. Restart everything (flush_memcached, restart_all, clear browser cache).
> 6. Repeat step 2.
> 7. New codes and values are now lsited.

Hello David, 

Indeed there are some terms which are not exactly the same as those of the ifla document, I propose a correction of those in a differentiated commit (only concerning the section "Script of title" to be precise with the BZ title).

I took the opportunity to change the title of the BZ, there was an error concerning the value builder, it is 100 and not 110 as previously indicated.

Thanks
Comment 12 David Nind 2023-05-15 00:08:58 UTC
Created attachment 151178 [details] [review]
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Signed-off-by: David Nind <david@davidnind.com>
Comment 13 David Nind 2023-05-15 00:09:01 UTC
Created attachment 151179 [details] [review]
Bug 33686: Correction of existing terms related to 'Script of title'

According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Signed-off-by: David Nind <david@davidnind.com>
Comment 14 Jonathan Druart 2023-05-17 14:04:24 UTC
Created attachment 151340 [details] [review]
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 15 Jonathan Druart 2023-05-17 14:04:27 UTC
Created attachment 151341 [details] [review]
Bug 33686: Correction of existing terms related to 'Script of title'

According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 16 Tomás Cohen Arazi 2023-05-18 14:04:47 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 17 Matt Blenkinsop 2023-06-08 16:43:17 UTC
Nice work everyone!

Pushed to stable for 22.11.x