Bug 33787

Summary: Remove option to archive system debit types
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: System AdministrationAssignee: Martin Renvoize <martin.renvoize>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Bug Depends on: 32450    
Bug Blocks:    
Attachments: Bug 33787: Fix for regression caused by bug 32450
Bug 33787: Fix for regression caused by bug 32450

Description Caroline Cyr La Rose 2023-05-19 17:34:30 UTC
It should not be possible to archive system debit types (such as ACCOUNT, OVERDUE, RENT, etc).

Only the manual types should have that option.

To recreate:
1. Go to Administration > Debit types
2. Click Show all debit types
   --> Note that *all* debit types have both the Edit and Archive buttons

Possibly a regression from bug 32450
Comment 1 Caroline Cyr La Rose 2023-05-19 17:37:22 UTC
I tried Martin's fix 
https://gitlab.com/mrenvoize/Koha/-/commit/824e4220c712b2a9de9e5666216f6d853889d46f

And it works. Ready to sign-off :)
Comment 2 Martin Renvoize 2023-05-22 08:46:30 UTC
Created attachment 151505 [details] [review]
Bug 33787: Fix for regression caused by bug 32450

This patch fixes the regression cashed by bug 32450 where we
accidentally introduced the option to archive system debit types.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Martin Renvoize 2023-05-22 08:47:00 UTC
Thanks for spotting this, reporting it and then testing the fix Caroline :)
Comment 4 Marcel de Rooy 2023-05-22 11:47:03 UTC
Created attachment 151512 [details] [review]
Bug 33787: Fix for regression caused by bug 32450

This patch fixes the regression cashed by bug 32450 where we
accidentally introduced the option to archive system debit types.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-05-22 17:46:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-08 17:09:36 UTC
Nice work everyone!

Pushed to stable for 22.11.x