Bug 33843

Summary: Use filter_by_last_update in Koha::Notice::Util
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 33837    
Bug Blocks:    
Attachments: Bug 33843: Use filter_by_last_update in Koha::Notice::Util
Bug 33843: Use filter_by_last_update in Koha::Notice::Util
Bug 33843: Use filter_by_last_update in Koha::Notice::Util
Bug 33843: Use filter_by_last_update in Koha::Notice::Util
Bug 33843: Use filter_by_last_update in Koha::Notice::Util

Description Marcel de Rooy 2023-05-26 08:19:19 UTC
Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837.
Comment 1 Marcel de Rooy 2023-05-26 08:22:08 UTC
Created attachment 151725 [details] [review]
Bug 33843: Use filter_by_last_update in Koha::Notice::Util

Resolve FIXME in sub _get_domain_count by using new datetime parameter
from bug 33837.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t.
This triggers the _get_domain_count call using the filter.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-07-26 12:26:27 UTC
Created attachment 153921 [details] [review]
Bug 33843: Use filter_by_last_update in Koha::Notice::Util

Resolve FIXME in sub _get_domain_count by using new datetime parameter
from bug 33837.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t.
This triggers the _get_domain_count call using the filter.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-07-26 12:26:59 UTC
 OK     Koha/Notice/Util.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

prove t/db_dependent/Koha/Notice_Util.t
t/db_dependent/Koha/Notice_Util.t .. ok
All tests successful.
Files=1, Tests=4,  3 wallclock secs ( 0.04 usr  0.01 sys +  2.64 cusr  0.30 csys =  2.99 CPU)
Result: PASS
Comment 4 Marcel de Rooy 2023-07-26 12:27:48 UTC
Created attachment 153922 [details] [review]
Bug 33843: Use filter_by_last_update in Koha::Notice::Util

Resolve FIXME in sub _get_domain_count by using new logic
from bug 33837.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t.
This triggers the _get_domain_count call using the filter.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 David Nind 2023-08-15 12:26:48 UTC
Created attachment 154432 [details] [review]
Bug 33843: Use filter_by_last_update in Koha::Notice::Util

Resolve FIXME in sub _get_domain_count by using new logic
from bug 33837.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t.
This triggers the _get_domain_count call using the filter.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Jonathan Druart 2023-09-01 11:58:24 UTC
Created attachment 155103 [details] [review]
Bug 33843: Use filter_by_last_update in Koha::Notice::Util

Resolve FIXME in sub _get_domain_count by using new logic
from bug 33837.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t.
This triggers the _get_domain_count call using the filter.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Tomás Cohen Arazi 2023-10-11 13:34:20 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-12 21:05:55 UTC
Depends on Bug 33837 not in 23.05.x