Bug 33858

Summary: Date for pending offline circulation is unformatted
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: cecile.lambour, gmcharlt, jonathan.druart, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Attachments: Bug 33858: Format dates in offline circ
Bug 33858: Format dates in offline circ
Bug 33858: Format dates in offline circ
Bug 33858: Format dates in offline circ

Description Katrin Fischer 2023-05-29 17:41:03 UTC
Following the test plan on bug 33838 (includes a koc test file) I noticed that the date in the pending offline circulations table is not formatted according to the DateFormat system preference.
Comment 1 Jonathan Druart 2023-06-07 08:57:59 UTC
Created attachment 152079 [details] [review]
Bug 33858: Format dates in offline circ
Comment 2 Jonathan Druart 2023-06-07 08:58:13 UTC
Should be as simple as that, but I have not tested the patch.
Comment 3 Katrin Fischer 2023-06-08 23:16:56 UTC
Created attachment 152225 [details] [review]
Bug 33858: Format dates in offline circ

1 - check item 3999900000001 out to a patron
2 - upload the attached KOC file from bug 33838
3 - navigate to pending offline circ actions
4 - verify that the date is shown unformatted
5 - apply patch
6 - verify that the date is now shown formatted

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-06-08 23:17:57 UTC
It works, but I updated it to use with_hours=1 to show the time, but we are still losing the second. Should we worry about that?
Comment 5 Biblibre Sandboxes 2023-06-30 09:48:15 UTC
Created attachment 152893 [details] [review]
Bug 33858: Format dates in offline circ

1 - check item 3999900000001 out to a patron
2 - upload the attached KOC file from bug 33838
3 - navigate to pending offline circ actions
4 - verify that the date is shown unformatted
5 - apply patch
6 - verify that the date is now shown formatted

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Univ Brest <cecile.lambour@univ-brest.fr>
Comment 6 Katrin Fischer 2023-06-30 09:58:06 UTC
Hi Cecile, is it a problem for you that the seconds part of the timestamp is missing or would that be ok?
Comment 7 Dept Num 2023-06-30 10:09:11 UTC
Hi Katrin,
I don't use the feature.
Comment 8 Katrin Fischer 2023-07-07 11:27:15 UTC
Created attachment 153156 [details] [review]
Bug 33858: Format dates in offline circ

1 - check item 3999900000001 out to a patron
2 - upload the attached KOC file from bug 33838
3 - navigate to pending offline circ actions
4 - verify that the date is shown unformatted
5 - apply patch
6 - verify that the date is now shown formatted

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Univ Brest <cecile.lambour@univ-brest.fr>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 9 Tomás Cohen Arazi 2023-07-07 12:18:51 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Martin Renvoize 2023-07-18 09:12:00 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 11 Matt Blenkinsop 2023-07-18 13:46:28 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x