Bug 33944

Summary: When listing checkouts, don't fetch item object if not using recalls
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CirculationAssignee: Nick Clemens (kidclamp) <nick>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Attachments: Bug 33944: Don't fetch item object unless using recalls
Bug 33944: Don't fetch item object unless using recalls
Bug 33944: Don't fetch item object unless using recalls

Description Nick Clemens (kidclamp) 2023-06-07 18:02:20 UTC
In svc/checkouts we fetch the item object, but it is only used if using recalls.
Comment 1 Nick Clemens (kidclamp) 2023-06-07 18:06:09 UTC
Created attachment 152127 [details] [review]
Bug 33944: Don't fetch item object unless using recalls

To test:
1 - Check someitems out to a patron
2 - View thier checkouts
3 - Apply patch, restart_all
4 - Confirm checkouts load as before
5 - Enable recalls
6 - Recall an item checked out to this patron
7 - Confirm recall shows as expected
Comment 2 Sam Lau 2023-06-07 18:29:21 UTC
Created attachment 152129 [details] [review]
Bug 33944: Don't fetch item object unless using recalls

To test:
1 - Check someitems out to a patron
2 - View thier checkouts
3 - Apply patch, restart_all
4 - Confirm checkouts load as before
5 - Enable recalls
6 - Recall an item checked out to this patron
7 - Confirm recall shows as expected

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-06-22 22:12:40 UTC
First strike, Nick - you forgot Assignee again :P
Comment 4 Katrin Fischer 2023-06-22 22:15:44 UTC
Created attachment 152607 [details] [review]
Bug 33944: Don't fetch item object unless using recalls

To test:
1 - Check someitems out to a patron
2 - View thier checkouts
3 - Apply patch, restart_all
4 - Confirm checkouts load as before
5 - Enable recalls
6 - Recall an item checked out to this patron
7 - Confirm recall shows as expected

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-06-23 12:46:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize 2023-07-17 14:03:01 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 7 Pedro Amorim 2023-07-18 11:54:40 UTC
Nice work everyone!

Pushed to 22.11.x for next release