Bug 34415

Summary: Remove Test::DBIx::Class from t/EdiTransport.t
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on:    
Bug Blocks: 34336    
Attachments: Bug 34415: Remove T::D::C from EdiTransport.t
Bug 34415: Move to db_dependent
Bug 34415: Perltidy file
Bug 34415: (follow-up) Fix count and copy file
Bug 34415: Remove T::D::C from EdiTransport.t
Bug 34415: Move to db_dependent
Bug 34415: Perltidy file
Bug 34415: (follow-up) Fix count and copy file
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db

Description Marcel de Rooy 2023-07-26 07:28:45 UTC
Remove Test::DBIx::Class
Comment 1 Marcel de Rooy 2023-07-26 11:34:00 UTC
Created attachment 153906 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-07-26 11:34:03 UTC
Created attachment 153907 [details] [review]
Bug 34415: Move to db_dependent

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-07-26 11:34:05 UTC
Created attachment 153908 [details] [review]
Bug 34415: Perltidy file

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2023-07-26 11:34:07 UTC
Created attachment 153909 [details] [review]
Bug 34415: (follow-up) Fix count and copy file

Instead of assuming a count of 0, I added an initial count.
By moving the test, we need to copy the test file with quotes.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2023-07-27 09:06:40 UTC
Created attachment 153943 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2023-07-27 09:06:43 UTC
Created attachment 153944 [details] [review]
Bug 34415: Move to db_dependent

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-07-27 09:06:45 UTC
Created attachment 153945 [details] [review]
Bug 34415: Perltidy file

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-07-27 09:06:48 UTC
Created attachment 153946 [details] [review]
Bug 34415: (follow-up) Fix count and copy file

Instead of assuming a count of 0, I added an initial count.
By moving the test, we need to copy the test file with quotes.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-07-27 09:07:02 UTC
I would squash the first 3 patches.
Comment 10 Jonathan Druart 2023-09-01 10:17:33 UTC
Marcel, shouldn't we actually access the edi_files like $BIN/../../.. instead of duplicating a file?
Comment 11 Marcel de Rooy 2023-09-02 12:57:02 UTC
(In reply to Jonathan Druart from comment #10)
> Marcel, shouldn't we actually access the edi_files like $BIN/../../..
> instead of duplicating a file?

Yeah. Will adjust.
Comment 12 Marcel de Rooy 2023-09-02 13:43:16 UTC
Created attachment 155174 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db

Moving file now here.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Marcel de Rooy 2023-09-02 13:44:11 UTC
(In reply to Jonathan Druart from comment #9)
> I would squash the first 3 patches.

All squashed now.
Comment 14 Martin Renvoize 2023-09-18 10:55:02 UTC
Created attachment 155798 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db

Moving file now here.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 15 Martin Renvoize 2023-09-18 10:55:50 UTC
Nice cleanup, Passing QA
Comment 16 Tomás Cohen Arazi 2023-09-18 15:06:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Fridolin Somers 2023-09-18 21:06:57 UTC
Enhancement not pushed to 23.05.x