Bug 34446

Summary: Typo: Can be guarantee
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Laura Escamilla <Laura.escamilla>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, Laura.escamilla
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Attachments: Bug 34446: Added missing colon to Can be guarantee
Bug 34446: Added missing colon to Can be guarantee
Bug 34446: (QA follow-up) Add colons on delete confirm page

Description Katrin Fischer 2023-07-31 09:51:18 UTC
The setting's label in administration > patron categories is missing a colon at the end:

Can be guarantee:
Comment 1 Laura Escamilla 2023-09-21 21:02:04 UTC
Created attachment 156012 [details] [review]
Bug 34446: Added missing colon to Can be guarantee

To test:

1. Go to Administration > patron categories and edit or create a new category. Notice that “Can be guarantee” does not have a colon. 
2. Apply patch and refresh the page. 
3. Can be guarantee now has a colon — yay!
4. Sign off and have a great day. :)
Comment 2 Katrin Fischer 2023-09-21 21:39:42 UTC
Hi Laura, your patch is missing the nice test plan you wrote - I believe you might have added it in the 'git bz attach' patch. This only adds it to bugzilla, but not to your patch file. You need to add it with "git commit".
Comment 3 Katrin Fischer 2023-09-21 21:40:48 UTC
Created attachment 156021 [details] [review]
Bug 34446: Added missing colon to Can be guarantee

To test:

1. Go to Administration > patron categories and edit or create a new category. Notice that “Can be guarantee” does not have a colon.
2. Apply patch and refresh the page.
3. Can be guarantee now has a colon — yay!
4. Sign off and have a great day. :)
Comment 4 Katrin Fischer 2023-09-21 21:40:50 UTC
Created attachment 156022 [details] [review]
Bug 34446: (QA follow-up) Add colons on delete confirm page

This adds the missing colon on the 'confirm deletion' page.
Comment 5 Katrin Fischer 2023-09-21 21:41:38 UTC
Using my super powers :) - PQA
Comment 6 Laura Escamilla 2023-09-22 12:05:34 UTC
(In reply to Katrin Fischer from comment #2)
> Hi Laura, your patch is missing the nice test plan you wrote - I believe you
> might have added it in the 'git bz attach' patch. This only adds it to
> bugzilla, but not to your patch file. You need to add it with "git commit".

I'll make sure to do that next time. Thank you, Katrin!
Comment 7 Tomás Cohen Arazi 2023-09-22 14:35:03 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-05 18:34:06 UTC
Pushed to 23.05.x for 23.05.05
Comment 9 Jacob O'Mara 2023-10-17 13:37:39 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x