Summary: | opac-imageviewer.pl not showing thumbnails | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | OPAC | Assignee: | David Cook <dcook> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
Bug Depends on: | |||
Bug Blocks: | 34724 | ||
Attachments: |
Bug 34723: Show thumbnails on opac-imageviewer.pl when imagenumber not provided
Bug 34723: Show thumbnails on opac-imageviewer.pl when imagenumber not provided Bug 34723: Show thumbnails on opac-imageviewer.pl when imagenumber not provided |
Description
David Cook
2023-09-06 06:27:32 UTC
Created attachment 155254 [details] [review] Bug 34723: Show thumbnails on opac-imageviewer.pl when imagenumber not provided This patch fixes a method call in the opac-imageviewer.pl so that thumbnails correctly appear. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=localcover 2. Change both *LocalCoverImages sysprefs to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AllowMultipleCovers 4. Change "AllowMultipleCovers" to "Allow" 5. Click "Images (0)" tab 6. Download or make two JPEG images 7. Upload the images 8. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=29 9. See one large image in the centre and two smaller thumbnails on the right side Created attachment 155298 [details] [review] Bug 34723: Show thumbnails on opac-imageviewer.pl when imagenumber not provided This patch fixes a method call in the opac-imageviewer.pl so that thumbnails correctly appear. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=localcover 2. Change both *LocalCoverImages sysprefs to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AllowMultipleCovers 4. Change "AllowMultipleCovers" to "Allow" 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 6. Click "Images (0)" tab 7. Download or make two JPEG images 8. Upload the images 9. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=29 10. See one large image in the centre and two smaller thumbnails on the right side PA amended patch: Added missing test plan step Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 155518 [details] [review] Bug 34723: Show thumbnails on opac-imageviewer.pl when imagenumber not provided This patch fixes a method call in the opac-imageviewer.pl so that thumbnails correctly appear. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=localcover 2. Change both *LocalCoverImages sysprefs to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AllowMultipleCovers 4. Change "AllowMultipleCovers" to "Allow" 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 6. Click "Images (0)" tab 7. Download or make two JPEG images 8. Upload the images 9. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=29 10. See one large image in the centre and two smaller thumbnails on the right side PA amended patch: Added missing test plan step Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |