Bug 34831

Summary: Add input types "tel", "email" and "url" to vendor edit form
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Attachments: Bug 34831: Add input types "tel", "email" and "url" to vendor edit form
Bug 34831: Add input types "tel", "email" and "url" to vendor edit form
Bug 34831: Add input types "tel", "email" and "url" to vendor edit form

Description Owen Leonard 2023-09-19 13:58:22 UTC
Replacing the generic input type attribute "text" can improve browsers' handling of the fields, for instance "validation parameters and relevant keyboard in supporting browsers and devices with dynamic keyboards."

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input
Comment 1 Owen Leonard 2023-09-19 14:42:24 UTC
Created attachment 155898 [details] [review]
Bug 34831: Add input types "tel", "email" and "url" to vendor edit form

This patch updates the vendor edit form so that phone, email, and url
fields have an input type corresponding to the field's content.

To test, apply the patch and go to Acquisitions.

- Create or edit a vendor.
- In the form, check that each field looks correct:
  - Company details ->
    - Phone
    - Fax
    - Website
  - Contact details
    - Phone
    - Alternative phone
    - Fax
    - Email
  - Interfaces
    - URI
    - Account email

In a desktop browser the inputs won't display any differently, but if
you test the patch in a sandbox you can try it in a mobile device
browser to confirm that the onscreen keyboard changes based on the type
of input.
Comment 2 Emily-Rose Francoeur 2023-09-26 15:40:10 UTC
Created attachment 156235 [details] [review]
Bug 34831: Add input types "tel", "email" and "url" to vendor edit form

This patch updates the vendor edit form so that phone, email, and url
fields have an input type corresponding to the field's content.

To test, apply the patch and go to Acquisitions.

- Create or edit a vendor.
- In the form, check that each field looks correct:
  - Company details ->
    - Phone
    - Fax
    - Website
  - Contact details
    - Phone
    - Alternative phone
    - Fax
    - Email
  - Interfaces
    - URI
    - Account email

In a desktop browser the inputs won't display any differently, but if
you test the patch in a sandbox you can try it in a mobile device
browser to confirm that the onscreen keyboard changes based on the type
of input.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 3 Katrin Fischer 2023-09-29 14:55:15 UTC
Created attachment 156409 [details] [review]
Bug 34831: Add input types "tel", "email" and "url" to vendor edit form

This patch updates the vendor edit form so that phone, email, and url
fields have an input type corresponding to the field's content.

To test, apply the patch and go to Acquisitions.

- Create or edit a vendor.
- In the form, check that each field looks correct:
  - Company details ->
    - Phone
    - Fax
    - Website
  - Contact details
    - Phone
    - Alternative phone
    - Fax
    - Email
  - Interfaces
    - URI
    - Account email

In a desktop browser the inputs won't display any differently, but if
you test the patch in a sandbox you can try it in a mobile device
browser to confirm that the onscreen keyboard changes based on the type
of input.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi 2023-10-20 14:48:43 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-26 06:07:39 UTC
Enhancement not pushed to 23.05.x