Summary: | reports-home.pl has unnecessary syspref template parameters | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Reports | Assignee: | David Cook <dcook> |
Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
Attachments: |
Bug 34859: Remove unnecessary params from reports-home.pl
Bug 34859: Remove unnecessary params from reports-home.pl Bug 34859: Remove unnecessary params from reports-home.pl |
Description
David Cook
2023-09-21 01:18:21 UTC
I've removed the unnecessary system preference template parameters and I've tidied the code. This script is pretty much the smallest controller you can make in Koha presently. (If we were using Mojolicious like in bug 31380, this script would actually be at most a small function within a greater controller module.) Created attachment 155965 [details] [review] Bug 34859: Remove unnecessary params from reports-home.pl This change removes unnecessary syspref template parameters and tidies the code. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 2. Add the following and save: <li><a href="#">Awesome</a></li> 3. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet 4. Add the following and save: http://bad 5. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet 6. Add the following and save: http://bad2 7. Go to /cgi-bin/koha/reports/reports-home.pl 8. Note the "Awesome" link in the top navbar 9. Note in the console that there are two errors where http://bad and http://bad2 can't be resolved Created attachment 156238 [details] [review] Bug 34859: Remove unnecessary params from reports-home.pl This change removes unnecessary syspref template parameters and tidies the code. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 2. Add the following and save: <li><a href="#">Awesome</a></li> 3. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet 4. Add the following and save: http://bad 5. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet 6. Add the following and save: http://bad2 7. Go to /cgi-bin/koha/reports/reports-home.pl 8. Note the "Awesome" link in the top navbar 9. Note in the console that there are two errors where http://bad and http://bad2 can't be resolved Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 156284 [details] [review] Bug 34859: Remove unnecessary params from reports-home.pl This change removes unnecessary syspref template parameters and tidies the code. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 2. Add the following and save: <li><a href="#">Awesome</a></li> 3. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet 4. Add the following and save: http://bad 5. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet 6. Add the following and save: http://bad2 7. Go to /cgi-bin/koha/reports/reports-home.pl 8. Note the "Awesome" link in the top navbar 9. Note in the console that there are two errors where http://bad and http://bad2 can't be resolved Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |