Bug 35065

Summary: Convert SelfCheckHelpMessage system preference to HTML customization
Product: Koha Reporter: Owen Leonard <oleonard>
Component: Self checkoutAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/777
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 31383, 35063    
Bug Blocks: 26050, 35151    
Attachments: Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: (follow-up) Add entry to HTML customization help include
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: (follow-up) Add entry to HTML customization help include
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: (follow-up) Add entry to HTML customization help include
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization
Bug 35065: (follow-up) Add entry to HTML customization help include
Bug 35065: (follow-up) Atomic update fixes

Description Owen Leonard 2023-10-16 16:08:49 UTC
Building on 22318, the SelfCheckHelpMessage system preference should be converted to an HTML customization option.
Comment 1 Owen Leonard 2023-10-16 16:37:04 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-10-20 17:46:49 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-10-21 00:22:08 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2023-10-25 16:26:10 UTC
Created attachment 157844 [details] [review]
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization

This patch moves the SelfCheckHelpMessage system preference into HTML
customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the SelfCheckHelpMessage
system preference before applying the patch. Apply the patch, run the
database update process, and rebuild the OPAC CSS.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from SelfCheckHelpMessage is now stored there.
- The HTML customization entry form should offer SelfCheckHelpMessage
  as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Enable the "opaclanguagesdisplay" preference if necessary.
- Edit the SelfCheckHelpMessage HTML customization and add unique
  content to the "fr-FR" tab.

- Log into the self checkout system and click the "Help" link at the
  top.
- On the help page, confirm that the SelfCheckHelpMessage content is
  shown there.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "SelfCheckHelpMessage." It should return no results.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Owen Leonard 2023-10-25 16:26:12 UTC
Created attachment 157845 [details] [review]
Bug 35065: (follow-up) Add entry to HTML customization help include
Comment 6 Owen Leonard 2023-10-26 14:05:58 UTC
Created attachment 157926 [details] [review]
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization

This patch moves the SelfCheckHelpMessage system preference into HTML
customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the SelfCheckHelpMessage
system preference before applying the patch. Apply the patch, run the
database update process, and rebuild the OPAC CSS.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from SelfCheckHelpMessage is now stored there.
- The HTML customization entry form should offer SelfCheckHelpMessage
  as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Enable the "opaclanguagesdisplay" preference if necessary.
- Edit the SelfCheckHelpMessage HTML customization and add unique
  content to the "fr-FR" tab.

- Log into the self checkout system and click the "Help" link at the
  top.
- On the help page, confirm that the SelfCheckHelpMessage content is
  shown there.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "SelfCheckHelpMessage." It should return no results.

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Owen Leonard 2023-10-26 14:06:00 UTC
Created attachment 157927 [details] [review]
Bug 35065: (follow-up) Add entry to HTML customization help include
Comment 8 Katrin Fischer 2023-11-05 11:30:46 UTC
Created attachment 158457 [details] [review]
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization

This patch moves the SelfCheckHelpMessage system preference into HTML
customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the SelfCheckHelpMessage
system preference before applying the patch. Apply the patch, run the
database update process, and rebuild the OPAC CSS.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from SelfCheckHelpMessage is now stored there.
- The HTML customization entry form should offer SelfCheckHelpMessage
  as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Enable the "opaclanguagesdisplay" preference if necessary.
- Edit the SelfCheckHelpMessage HTML customization and add unique
  content to the "fr-FR" tab.

- Log into the self checkout system and click the "Help" link at the
  top.
- On the help page, confirm that the SelfCheckHelpMessage content is
  shown there.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "SelfCheckHelpMessage." It should return no results.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2023-11-05 11:30:49 UTC
Created attachment 158458 [details] [review]
Bug 35065: (follow-up) Add entry to HTML customization help include

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Owen Leonard 2023-11-09 14:56:09 UTC
Created attachment 158738 [details] [review]
Bug 35065: Convert SelfCheckHelpMessage system preference to HTML customization

This patch moves the SelfCheckHelpMessage system preference into HTML
customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the SelfCheckHelpMessage
system preference before applying the patch. Apply the patch, run the
database update process, and rebuild the OPAC CSS.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from SelfCheckHelpMessage is now stored there.
- The HTML customization entry form should offer SelfCheckHelpMessage
  as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Enable the "opaclanguagesdisplay" preference if necessary.
- Edit the SelfCheckHelpMessage HTML customization and add unique
  content to the "fr-FR" tab.

- Log into the self checkout system and click the "Help" link at the
  top.
- On the help page, confirm that the SelfCheckHelpMessage content is
  shown there.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "SelfCheckHelpMessage." It should return no results.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Owen Leonard 2023-11-09 14:56:11 UTC
Created attachment 158739 [details] [review]
Bug 35065: (follow-up) Add entry to HTML customization help include

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Owen Leonard 2023-11-09 14:56:13 UTC
Created attachment 158740 [details] [review]
Bug 35065: (follow-up) Atomic update fixes
Comment 13 Tomás Cohen Arazi 2023-11-09 17:50:42 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-11-11 07:27:49 UTC
Enhancement not pushed to 23.05.x