Bug 35093

Summary: ILL table is broken
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Bugs List <koha-bugs>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: major    
Priority: P5 - low CC: fridolin.somers, martin.renvoize, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 30719    
Bug Blocks: 35094    
Attachments: Bug 35093: Update batch to ill_batch embed
Bug 35093: Update batch to ill_batch embed
Bug 35093: Update batch to ill_batch embed

Description Pedro Amorim 2023-10-18 15:29:16 UTC
Caused by last minute refactoring of 30719.

To reproduce:
Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

BOOM
Comment 1 Pedro Amorim 2023-10-18 15:30:30 UTC
Created attachment 157337 [details] [review]
Bug 35093: Update batch to ill_batch embed

Test plan:

Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

Notice the table now renders correctly
Comment 2 Lucas Gass 2023-10-18 23:09:26 UTC
Created attachment 157363 [details] [review]
Bug 35093: Update batch to ill_batch embed

Test plan:

Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

Notice the table now renders correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Martin Renvoize 2023-10-19 10:58:58 UTC
Created attachment 157419 [details] [review]
Bug 35093: Update batch to ill_batch embed

Test plan:

Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

Notice the table now renders correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-10-19 10:59:25 UTC
Trivial fix for major issue.

Passing QA
Comment 5 Tomás Cohen Arazi 2023-10-19 19:02:29 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-25 08:13:39 UTC
Depends on Bug 30719 not in 23.05.x