Bug 3524

Summary: Display of item type image/description when placing holds (broken image / no description)
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: gmcharlt, nengard, oleonard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: screenshot: no image defined for item type
screenshot: image defined, decription missing
Proposed fix
Follow-up patch

Description Chris Cormack 2010-05-21 01:11:44 UTC


---- Reported by katrin.fischer@bsz-bw.de 2009-08-12 08:42:37 ----

When placing a hold in OPAC with syspref OpacItemHolds ON the item type is not displayed correctly.

When no image is defined for the item type, the description of the item type from alt-attrbute is displayed, but you see a 'broken-link-image'.

After adding an image to the item type, the image is displayed correctly, but the description is missing.

(see screenshots)

HTML from template:

  <td>
     <img src=""
     alt="normale Ausleihe"
     title="normale Ausleihe" />
  </td>

  <td>
     <img src="/opac-tmpl/prog/itemtypeimg/npl/Non-fiction.gif"
     alt="normale Ausleihe"
     title="normale Ausleihe" />
  </td>



---- Additional Comments From katrin.fischer@bsz-bw.de 2009-08-12 08:43:45 ----

Created an attachment
screenshot: no image defined for item type





---- Additional Comments From katrin.fischer@bsz-bw.de 2009-08-12 08:44:33 ----

Created an attachment
screenshot: image defined, decription missing





---- Additional Comments From oleonard@myacpl.org 2009-08-28 13:39:47 ----

Created an attachment
Proposed fix





---- Additional Comments From gmcharlt@gmail.com 2009-09-06 18:42:37 ----

Patch pushed.  Please test and close.



---- Additional Comments From nengard@gmail.com 2009-09-08 00:02:55 ----

I am looking at this in the the staff client and I still only see the image - not the text description - is that the intended behavior?



---- Additional Comments From oleonard@myacpl.org 2009-09-10 15:20:40 ----

Created an attachment
Follow-up patch





---- Additional Comments From gmcharlt@gmail.com 2009-09-12 13:12:57 ----

Pushed follow-up patch.  Please test and close.



---- Additional Comments From katrin.fischer@bsz-bw.de 2009-09-23 19:28:14 ----

Tested with current HEAD. 

Description is now shown in OPAC and intranet with and without defined item type image.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:11 UTC  ---

This bug was previously known as _bug_ 3524 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3524
Imported an attachment (id=1385)
Imported an attachment (id=1386)
Imported an attachment (id=1387)
Imported an attachment (id=1388)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1385 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1386 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1387 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1388 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.