Bug 35354

Summary: Update emailLibrarianWhenHoldisPlaced system preference description
Product: Koha Reporter: Kelly McElligott <kelly>
Component: DocumentationAssignee: Katrin Fischer <katrin.fischer>
Status: Pushed to oldstable --- QA Contact: Martin Renvoize <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, lucas, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09
Attachments: Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference
Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference
Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference

Description Kelly McElligott 2023-11-16 18:18:43 UTC
The system preference, emaillibrarianwhenholdisplaced, states, "sending an email to the Koha administrator email address whenever a hold request is placed". However, this will be sent to the library's email address if they are set up in  Libraries . The fact that Koha says the email gets sent out to the Koha Admin Email would not be helpful for multi-site libraries within Koha. With more in the system preference, libraries could know more about how this will work for their set up.
Comment 1 Katrin Fischer 2024-01-13 15:24:02 UTC
    # Send e-mail to librarian if syspref is active
    if(C4::Context->preference("emailLibrarianWhenHoldIsPlaced")){
        my $patron = $hold->patron;
        my $library = $patron->library;
        if ( my $letter =  C4::Letters::GetPreparedLetter (
            module => 'reserves',
            letter_code => 'HOLDPLACED',
            branchcode => $branch,
            lang => $patron->lang,
            tables => {
                'branches'    => $library->unblessed,
                'borrowers'   => $patron->unblessed,
                'biblio'      => $biblionumber,
                'biblioitems' => $biblionumber,
                'items'       => $checkitem,
                'reserves'    => $hold->unblessed,
            },
        ) ) {

            my $branch_email_address = $library->inbound_email_address;

            C4::Letters::EnqueueLetter(
                {
                    letter                 => $letter,
                    borrowernumber         => $borrowernumber,
                    message_transport_type => 'email',
                    to_address             => $branch_email_address,
                }
            );
        }
    }
Comment 2 Katrin Fischer 2024-01-13 15:24:38 UTC
Created attachment 161014 [details] [review]
Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference

This includes more information about the email addresses
used in the system preference description.

To test:
* Search for EmailLibrarianWhenHoldisPlaced in administration >
  system preferences
* Verify description
* Apply patch
* Verify improved description and that the links work as expected
Comment 3 David Nind 2024-01-17 13:17:41 UTC
Created attachment 161103 [details] [review]
Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference

This includes more information about the email addresses
used in the system preference description.

To test:
* Search for EmailLibrarianWhenHoldisPlaced in administration >
  system preferences
* Verify description
* Apply patch
* Verify improved description and that the links work as expected

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Martin Renvoize 2024-01-23 17:14:49 UTC
Created attachment 161309 [details] [review]
Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference

This includes more information about the email addresses
used in the system preference description.

To test:
* Search for EmailLibrarianWhenHoldisPlaced in administration >
  system preferences
* Verify description
* Apply patch
* Verify improved description and that the links work as expected

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-01-26 14:17:39 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-01 13:44:04 UTC
Pushed to 23.11.x for 23.11.03
Comment 7 Fridolin Somers 2024-02-01 13:46:24 UTC
Note that system preference real name is : emailLibrarianWhenHoldIsPlaced
Comment 8 Lucas Gass 2024-02-09 20:45:17 UTC
Backported to 23.05.x for upcoming 23.05.09