Bug 35496

Summary: Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab
Product: Koha Reporter: Lucas Gass <lucas>
Component: OPACAssignee: Lucas Gass <lucas>
Status: Pushed to oldstable --- QA Contact: Victor Grousset/tuxayo <victor>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Bug Depends on: 35488    
Bug Blocks:    
Attachments: Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request
Bug 35496: (QA follow-up): tidy up code

Description Lucas Gass 2023-12-05 17:54:54 UTC
To recreate:
1 - Turn on ArticleRequests 
1 - Place an  Article Requests on the opac
2 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
3 - Note the article request tab is not active
Comment 1 Lucas Gass 2023-12-05 18:07:04 UTC
Created attachment 159605 [details] [review]
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request

To test:
1 - Turn on ArticleRequests
2 - Place an  Article Requests on the opac
3 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
4 - Note the article request tab is not active
5 - APPLY PATCH and restart_all
6. Try steps 2 - 4 again, this time the article request tab should be open by default.
Comment 2 David Nind 2023-12-05 23:40:20 UTC
Created attachment 159610 [details] [review]
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request

To test:
1 - Turn on ArticleRequests
2 - Place an  Article Requests on the opac
3 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
4 - Note the article request tab is not active
5 - APPLY PATCH and restart_all
6. Try steps 2 - 4 again, this time the article request tab should be open by default.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-12-13 15:40:24 UTC
Created attachment 159808 [details] [review]
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request

To test:
1 - Turn on ArticleRequests
2 - Place an  Article Requests on the opac
3 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
4 - Note the article request tab is not active
5 - APPLY PATCH and restart_all
6. Try steps 2 - 4 again, this time the article request tab should be open by default.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-13 15:40:26 UTC
Created attachment 159809 [details] [review]
Bug 35496: (QA follow-up): tidy up code
Comment 5 Victor Grousset/tuxayo 2023-12-13 15:45:03 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 6 Katrin Fischer 2023-12-14 15:31:53 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 14:11:04 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass 2024-01-04 18:51:50 UTC
Backported to 23.05.x for upcoming 23.05.08