Bug 35547

Summary: When using "Add to a list" button with more than 10 lists, "staff only" does not show up
Product: Koha Reporter: Kyle M Hall <kyle>
Component: ListsAssignee: Laura Escamilla <Laura.escamilla>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, kiehl, lucas, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
URL: addbybiblionumber.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Attachments: Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up
Bug 35547: Show public "staff only" lists in addbybiblionumber.pl

Description Kyle M Hall 2023-12-12 15:26:43 UTC
When adding an item to a list from catalogue/detail.pl, we can see the latest 10  public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does.

To reproduce:
1) Create 11 "staff only" lists as staff member A
2) Log in as staff member B
3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here
4) In the pulldown, choose the "More lists" option
5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list"
Comment 1 Kyle M Hall 2023-12-12 15:28:34 UTC
Created attachment 159743 [details] [review]
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up

When adding an item to a list from catalogue/detail.pl, we can see the latest 10  public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does.

Test plan:
1) Create 11 "staff only" lists as staff member A
2) Log in as staff member B
3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here
4) In the pulldown, choose the "More lists" option
5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list"
6) Apply this patch
7) Restart all the things!
8) Click the "More lists" option again
9) Those lists should now be in the pulldown!
Comment 2 Biblibre Sandboxes 2023-12-14 13:43:19 UTC
Created attachment 159836 [details] [review]
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up

When adding an item to a list from catalogue/detail.pl, we can see the latest 10  public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does.

Test plan:
1) Create 11 "staff only" lists as staff member A
2) Log in as staff member B
3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here
4) In the pulldown, choose the "More lists" option
5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list"
6) Apply this patch
7) Restart all the things!
8) Click the "More lists" option again
9) Those lists should now be in the pulldown!

Signed-off-by: sabrina <kiehl@mpis.mpg.de>
Comment 3 Sabrina Kiehl 2023-12-14 13:46:25 UTC
Followed all steps of the test plan and all lists are displayed after applying the patch.
Comment 4 ByWater Sandboxes 2023-12-15 12:06:47 UTC
Created attachment 159885 [details] [review]
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up

When adding an item to a list from catalogue/detail.pl, we can see the latest 10  public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does.

Test plan:
1) Create 11 "staff only" lists as staff member A
2) Log in as staff member B
3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here
4) In the pulldown, choose the "More lists" option
5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list"
6) Apply this patch
7) Restart all the things!
8) Click the "More lists" option again
9) Those lists should now be in the pulldown!

Signed-off-by: sabrina <kiehl@mpis.mpg.de>
Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi>
Comment 5 Julian Maurice 2023-12-22 08:16:44 UTC
Created attachment 160224 [details] [review]
Bug 35547: Show public "staff only" lists in addbybiblionumber.pl

When adding an item to a list from catalogue/detail.pl, we can see the
latest 10  public lists. If all those lists are set as "staff only" for
"Allow changes to contents from" they will not show up in the
addbybiblionumber.pl popup. This is because the query in the popup does
not look for "staff only" lists while the "Add to list" button does.

Test plan:
1) Create 11 "staff only" lists as staff member A
2) Log in as staff member B
3) Find a record, click the "Add to list" button, note you can see lists
   2 through 11 here
4) In the pulldown, choose the "More lists" option
5) Note those lists are not visible in the "Choose list" pulldown under
   "Select an existing list"
6) Apply this patch
7) Restart all the things!
8) Click the "More lists" option again
9) Those lists should now be in the pulldown!

Signed-off-by: sabrina <kiehl@mpis.mpg.de>
Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Katrin Fischer 2023-12-27 18:10:21 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 15:37:10 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass 2024-01-04 21:05:30 UTC
*** Bug 33722 has been marked as a duplicate of this bug. ***
Comment 9 Lucas Gass 2024-01-04 21:06:39 UTC
Backported to 23.05.x for upcoming 23.05.08