Bug 36375

Summary: Inconsistencies in ContentWarningField display
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: CatalogingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 31123    
Bug Blocks:    

Description Fridolin Somers 2024-03-20 15:29:06 UTC
Bug 31123 add code in XSLT files for results and details pages OPAC and staff interface.
Looks like those 4 displays are different, they use $a and $u then call subfieldSelect with different values :

koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwxyz</xsl:with-param>
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:
  <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param>
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param>
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param>

Using $a and $u is a mistake since they are displayed in above code.

In Bug 36370 I used code from MARC21slim2intranetDetail.xsl : bcdefghijklmnopqrstvwxyz
Looks like it is the better one.

Also makes sens to create a template in MARC21slimUtils.xsl