Summary: | The 'Subject(s)' link(s) are malformed resulting in no search results | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Nighswonger <cnighswonger> |
Component: | OPAC | Assignee: | Chris Nighswonger <cnighswonger> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | blocker | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cnighswonger, colin.campbell, henridamien |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Patch
Backport of fix to current 3.0.x branch Corrected patch Proposed patch |
Description
Chris Cormack
2010-05-21 01:22:51 UTC
The point raised by Henridamien is valid. In fact, the patch stops all simple searching under these conditions e.g. search for 'water' fails because the query string hits the regexes as kw,wrdl:water and the search as zebra sees it is for water AND kw AND wrdl. Whether all of the qualifiers are needed to be tested for is not certain but certainly wrdl needs to be added (and if we test for right truncation arn't other truncations equally valid? Created attachment 2762 [details] [review] Proposed patch This patch clears the major problem I encountered with the code as is. We may need to check for more cases. Arguably it might be better to parse the query string fully into its constituent parts /(index)?(, *qualifier)=/ Patch pushed, please test This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1. |