Bug 4311

Summary: OPACXSLTResultsDisplay preference does not work
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: major    
Priority: PATCH-Sent (DO NOT USE) CC: gmcharlt, jwagner, katrin.fischer, nengard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot of the problem

Description Chris Cormack 2010-05-21 01:25:40 UTC


---- Reported by oleonard@myacpl.org 2010-03-09 14:44:16 ----

Created an attachment
Screenshot of the problem

If you have OPACXSLTResultsDisplay turned ON and XSLTResultsDisplay turned OFF you will see results like in the attached screenshot.

With OPACXSLTResultsDisplay OFF and XSLTResultsDisplay ON you will see XSLT results in the OPAC.

In Search.pm:

        # XSLT processing of some stuff
	use C4::Charset;
	SetUTF8Flag($marcrecord);
	$debug && warn $marcrecord->as_formatted;
        if (C4::Context->preference("XSLTResultsDisplay") && !$scan) {
            $oldbiblio->{XSLTResultsRecord} = XSLTParse4Display(
                $oldbiblio->{biblionumber}, $marcrecord, 'Results' );
        }

Since there is not XSLT version of the results page in the staff client, a simple fix would be to change this preference check to one for OPACXSLTResultsDisplay.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:25 UTC  ---

This bug was previously known as _bug_ 4311 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4311
Imported an attachment (id=2001)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 2001 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2010-05-24 12:02:25 UTC
This problem still exists in 3.01.00.134.
Comment 2 Galen Charlton 2010-05-25 15:23:31 UTC
Pushed patch to fix this.  Please test and close.
Comment 3 Owen Leonard 2010-06-03 15:39:45 UTC
Tested with OPACXSLTResultsDisplay turned ON and XSLTResultsDisplay turned OFF,
tested with OPACXSLTResultsDisplay turned OFF and XSLTResultsDisplay turned ON.

OPAC results now work as expected in both cases.