Bug 4370

Summary: Incorrect ind1 semantics for MARC21 780/785
Product: Koha Reporter: Jared Camins <camins>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: gmcharlt
Version: unspecified   
Hardware: PC   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed fix

Description Chris Cormack 2010-05-21 01:26:22 UTC


---- Reported by camins@numismatics.org 2010-04-05 17:26:43 ----

The first indicator for MARC21 fields 76x-78x should control whether the entire field displays, not whether the $n subfield displays.

To reproduce: view a record that includes a 780 or 785 field with indicator 1 set to '1' and the system preference OPACXSLTDetailsDisplay enabled.

The 780/785 field will show up, but according to the standard no display should be generated when 780/785 indicator 1 is set to '1'.

In the MARC21slim2OPACDetail.xsl, MARC21 fields 780 and 785 are always displayed when present, and indicator 1 is used to determine whether or not to display 780$n and 785$n.



---- Additional Comments From camins@numismatics.org 2010-04-05 18:06:32 ----

Created an attachment
Proposed fix

Applying the attached diff (based off of tag v3.02.00-alpha) fixes the problem for us. Fields 780 and 785 are properly hidden when the first indicator is equal to '1'.



---- Additional Comments From gmcharlt@gmail.com 2010-04-30 02:33:14 ----

Patch pushed.  Please test and close.



---- Additional Comments From camins@numismatics.org 2010-05-03 16:10:18 ----

That fixed it, thanks. Setting resolution to FIXED.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:26 UTC  ---

This bug was previously known as _bug_ 4370 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4370
Imported an attachment (id=2051)

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 2051 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.