Bug 4805

Summary: Multiple subscriptionid's passed to serials-collection.
Product: Koha Reporter: Garry Collum <gcollum>
Component: SerialsAssignee: Garry Collum <gcollum>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: major    
Priority: P5 - low CC: gmcharlt
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patch
Propose patch - replacement for previous patch

Description Garry Collum 2010-05-22 15:57:15 UTC
In the serials-edit.tmpl subscriptionid is defined in every row (issue) of the serials edition table.  If you click on the save button, multiple subscriptionids are passed to the serials-collection page (serials-collection.pl?subscriptionid=3&subscriptionid=3&subscriptionid=3&subscriptionid=3).

This results in duplicate lines in the serials-collection page for each id that is passed.
Comment 1 Garry Collum 2010-05-22 16:07:12 UTC Comment hidden (obsolete)
Comment 2 Garry Collum 2010-05-22 16:51:55 UTC
Please ignore this patch.

It looks like serials-edit can edit more than one subscriptionid at a time, although I'm not sure how you would do this within contriving it.

The fix needs to be able to send multiple different subscription ids, or serials-collection needs to perform a DISTINCT function to eliminate duplicates.  Not passing duplicate ids in the first place would probably be preferable.
Comment 3 Garry Collum 2010-05-23 23:46:01 UTC
Created attachment 2160 [details] [review]
Propose patch - replacement for previous patch
Comment 4 Galen Charlton 2010-05-25 19:49:16 UTC
Pushed second patch.  Please test and close.