Summary: | In C4/XSLT.pm, itemcallnumber can contain special XML characters | ||
---|---|---|---|
Product: | Koha | Reporter: | Daniel Latrémolière <daniel.latremoliere> |
Component: | MARC Bibliographic data support | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Simple patch (only for '<').
Complete patch (for all XML special characters except ampersand) revised patch; defines new C4::Koha::xml_escape |
Description
Daniel Latrémolière
2010-10-13 14:27:05 UTC
Comment hidden (obsolete)
Created attachment 2687 [details] [review] Complete patch (for all XML special characters except ampersand) Submitted revised patch for inclusion in HEAD. Created attachment 2702 [details] [review] revised patch; defines new C4::Koha::xml_escape I have tested changes for the files C4/Koha.pm and C4/XSLT.pm without problems. It has good behaviour even on data containing '<'. This patch is vastly better than mine. Thank you very much for the clean refactoring.%0 Pushed to branch new/bug_5301 Please test and let me know and I will merge to master. > Pushed to branch new/bug_5301
>
> Please test and let me know and I will merge to master.
I have tested branch new/bug_5301.
Koha's behaviour is good, even on data containing '<'.
Thanks.
Pushed to master, please close if still working fine This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. |