Bug 5301

Summary: In C4/XSLT.pm, itemcallnumber can contain special XML characters
Product: Koha Reporter: Daniel Latrémolière <daniel.latremoliere>
Component: MARC Bibliographic data supportAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, koha.sekjal
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Simple patch (only for '<').
Complete patch (for all XML special characters except ampersand)
revised patch; defines new C4::Koha::xml_escape

Description Daniel Latrémolière 2010-10-13 14:27:05 UTC Comment hidden (obsolete)
Comment 1 Daniel Latrémolière 2010-10-13 14:28:37 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2010-10-27 12:24:57 UTC
Submitted revised patch for inclusion in HEAD.
Comment 3 Galen Charlton 2010-10-27 12:25:40 UTC
Created attachment 2702 [details] [review]
revised patch; defines new C4::Koha::xml_escape
Comment 4 Daniel Latrémolière 2010-10-28 07:34:13 UTC
I have tested changes for the files C4/Koha.pm and C4/XSLT.pm without problems. It has good behaviour even on data containing '<'.

This patch is vastly better than mine.
Thank you very much for the clean refactoring.%0
Comment 5 Chris Cormack 2010-11-01 19:35:08 UTC
Pushed to branch new/bug_5301

Please test and let me know and I will merge to master.
Comment 6 Daniel Latrémolière 2010-11-02 12:45:22 UTC
> Pushed to branch new/bug_5301
> 
> Please test and let me know and I will merge to master.

I have tested branch new/bug_5301.

Koha's behaviour is good, even on data containing '<'.

Thanks.
Comment 7 Chris Cormack 2010-11-02 17:57:59 UTC
Pushed to master, please close if still working fine
Comment 8 Chris Nighswonger 2010-11-18 03:15:10 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.