Bug 5454

Summary: Resolve BiblioAddAuthorities Name Conflict in addbiblio.pl
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: CatalogingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: P5 - low CC: koha.sekjal
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 7284    
Bug Blocks:    

Description Colin Campbell 2010-11-29 11:52:12 UTC
cataloguing/addbiblio.pl has a routine BiblioAddAuthorities which is almost identical to the subroutine of that name imported from Search.

Name clash should be resolved. If code exists in two places at least one is bound to be wrong
Comment 1 Galen Charlton 2011-03-03 21:40:33 UTC
Furthermore, the core routine BiblioAddAuthorities should not be in C4::Search.  C4::Biblio, C4::AuthoritiesMarc, or perhaps a new module would be better.
Comment 2 Jared Camins-Esakov 2012-01-07 17:02:27 UTC
This will be fixed as a side effect of the work on bug 7284.
Comment 3 Jared Camins-Esakov 2013-04-03 12:23:00 UTC
As stated in comment 2, this was fixed by bug 7284.