Bug 5526

Summary: List of lists should be in alphabetical order by list name
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ListsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: PATCH-Sent (DO NOT USE) CC: chris, nengard
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed fix
opac pull down
staff pull down

Description Owen Leonard 2010-12-20 15:08:28 UTC
The list of patron's lists comes from VirtualShelves.pm's GetShelves, which includes this in the SQL:

        ORDER BY virtualshelves.category
        DESC 

I think it makes more sense to order by virtualshelves.shelfname.
Comment 1 Owen Leonard 2010-12-20 15:11:50 UTC
Created attachment 2891 [details] [review]
Proposed fix
Comment 2 Chris Cormack 2010-12-29 07:42:47 UTC
Pushed, please test
Comment 3 Nicole C. Engard 2010-12-29 12:24:44 UTC
Created attachment 2915 [details]
opac pull down

this fix did not take into account the list of lists pull down in the opac
Comment 4 Nicole C. Engard 2010-12-29 12:25:05 UTC
Created attachment 2916 [details]
staff pull down

this fix did not take into account the list of lists pull down in the staff client
Comment 5 Owen Leonard 2010-12-29 13:46:53 UTC
> this fix did not take into account the list of lists pull down in the opac
> this fix did not take into account the list of lists pull down in the staff
> client

No, and it did not attempt to. The lists in the screenshots you attached are generated by a function that pulls the 10 most recent lists ordered by `lastmodified`, and the changes I made in this patch were made specifically to this page: /cgi-bin/koha/opac-shelves.pl?display=privateshelves

The GetRecentShelves subroutine could easily be made to order by list name, but I think it's contrary to the original intention of those displays.
Comment 6 Nicole C. Engard 2010-12-29 19:46:17 UTC
Okey Dokey, then this works as expected :)