Bug 5704

Summary: Optionally show record level item type icons in search results
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: NEW --- QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: P5 - low CC: jdemuth, kholt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 4359    
Bug Blocks:    
Attachments: display introduced with patch for bug 4359

Description Nicole C. Engard 2011-02-07 16:08:33 UTC
Created attachment 3079 [details]
display introduced with patch for bug 4359

I talked to Owen today (chat transcript below) about the recent changes applied by the commit for bug 4359.  Basically the icon shouldn't show on the search results unless the item-level_itypes pref is off.  But I think we need a new pref that does not take the item-level_itypes pref into consideration to show the bib level item type icon on the search results (if the library so chooses).



---------------

Owen Leonard: But if you have item-level item types turned on (and I think most people do now?) then there is no way to choose which item type to display on the results page
Owen Leonard: And mightn't libraries not be setting a biblio-level item type at all?
Nicole Engard: so maybe we need two prefs 
Nicole Engard: you are right - they may not be setting that bib level item type
Owen Leonard: Hm... They don't have some copies in reference and others which circulate?
Owen Leonard: That's the big use we have of the feature
Nicole Engard: i would think they would 
Nicole Engard: basically whatever commit this was needs to be reverted cause it has too many variables that weren't considered
Nicole Engard: i just can't find the report for it
Nicole Engard: i think we need multiple prefs:
Owen Leonard: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7a945dbc284a9fc98fda06a49bbac0712bce4fea
Nicole Engard: #1 show icons on the search results (yes/no)
Nicole Engard: #2 use the bib level/first item level icon for display
Nicole Engard: #3 show icons on the items on the bib detail
Owen Leonard: I'm going to submit another patch to make display of the item type icon contingent on having item-level_itypes off
Nicole Engard: i'll add my notes after you do that - cause that's too broad a condition - if you turn them off for all items and want the icon to display on the search results if you don't have attached items you can't have that
Nicole Engard: i don't know if that makes sense
Owen Leonard: I think at this point there is no logical way to display icons on the search results page if you have item-level itemtypes turned on.
Nicole Engard: hence my suggestions for multiple prefs
Owen Leonard: Displaying the first item-level item type doesn't make sense to me, I think that would be misinformation.
Nicole Engard: i agree with you!! don't get my wrong - i'm just telling you what we're being asked for
Nicole Engard: i'm okay with your way - but we need a pref to use the bib level item type for search results icon display if people want
Nicole Engard: and that has to be regardless of the value in the item level pref
Nicole Engard: who are we to tell libraries they can't share misinformation? :) hehe
Owen Leonard: Fair enough. 
Owen Leonard: So we need a new bug report for that enhancement
Nicole Engard: i'll do that and i'll relate it to the one you're fixing