Summary: | system preference to control "No cover image available" message | ||
---|---|---|---|
Product: | Koha | Reporter: | Reed Wade <reed> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, irma, mtj, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
pic showing FAILING CSS solution
pic showing FAILING JS solution |
Description
Reed Wade
2011-02-15 01:46:00 UTC
.. and no message border -- just whitespace How about this in OPACUserCSS: span.no-image { display: none; } Given the OPACUserCSS workaround I'm going to consider this WONTFIX. If anyone wants to argue please re-open. (In reply to Owen Leonard from comment #2) > How about this in OPACUserCSS: > > span.no-image { > display: none; > } (In reply to Owen Leonard from comment #3) > Given the OPACUserCSS workaround I'm going to consider this WONTFIX. If > anyone wants to argue please re-open. I just confirmed this CSS does not work for OPAC, with 'GoogleJackets' syspref enabled, on Koha 3.18.8 so, re-opening - can someone else confirm this please? Created attachment 44182 [details]
pic showing FAILING CSS solution
(In reply to Mason James from comment #4) > (In reply to Owen Leonard from comment #2) > > How about this in OPACUserCSS: > > > > span.no-image { > > display: none; > > } > > (In reply to Owen Leonard from comment #3) > > Given the OPACUserCSS workaround I'm going to consider this WONTFIX. If > > anyone wants to argue please re-open. > > I just confirmed this CSS does not work for OPAC, with 'GoogleJackets' > syspref enabled, > on Koha 3.18.8 ..also, for me, the JS solution described below does not work either http://wiki.koha-community.org/wiki/JQuery_Library#Show_nothing_when_cover_images_are_not_found Created attachment 44183 [details]
pic showing FAILING JS solution
Mason: Can you explain why Owen's CSS doesn't work for you? I've been using the CSS mentioned by Owen for a few years now and I haven't noticed any difficulties. Does Google Jackets use a different HTML element and/or class? (In reply to David Cook from comment #8) > Mason: Can you explain why Owen's CSS doesn't work for you? > > I've been using the CSS mentioned by Owen for a few years now and I haven't > noticed any difficulties. Does Google Jackets use a different HTML element > and/or class? for intranet search results, the amazon 'no image' element is not a 'no-image' class, so the following CSS will not work... span.no-image { display: none; } here is an example of the element <a class="p1" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=7327"> <img src="https://images-na.ssl-images-amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="" class="thumbnail"> </a> observed on Koha 3.20.06 (In reply to Mason James from comment #9) > (In reply to David Cook from comment #8) > > Mason: Can you explain why Owen's CSS doesn't work for you? > > > > I've been using the CSS mentioned by Owen for a few years now and I haven't > > noticed any difficulties. Does Google Jackets use a different HTML element > > and/or class? > > for intranet search results, the amazon 'no image' element is not a > 'no-image' class, so the following CSS will not work... but some good news, the CSS *does* seem to work for a GBK 'no-image' element so, apologies there :) (In reply to Mason James from comment #9) > (In reply to David Cook from comment #8) > > Mason: Can you explain why Owen's CSS doesn't work for you? > > > > I've been using the CSS mentioned by Owen for a few years now and I haven't > > noticed any difficulties. Does Google Jackets use a different HTML element > > and/or class? > > for intranet search results, the amazon 'no image' element is not a > 'no-image' class, so the following CSS will not work... hmm, the no-image jscript code in the intranet, does not add the 'no-image' class - unlike the OPAC version (In reply to Mason James from comment #11) > (In reply to Mason James from comment #9) > > (In reply to David Cook from comment #8) > > > Mason: Can you explain why Owen's CSS doesn't work for you? > > > > > > I've been using the CSS mentioned by Owen for a few years now and I haven't > > > noticed any difficulties. Does Google Jackets use a different HTML element > > > and/or class? > > > > for intranet search results, the amazon 'no image' element is not a > > 'no-image' class, so the following CSS will not work... > > hmm, the no-image jscript code in the intranet, does not add the 'no-image' > class > - unlike the OPAC version i've added a patch for this here... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 i think Owens CSS solution might work, after this patch is added :) Seems discussion is that we need consistent links and then CSS works here, making this a duplicate of 13597 to allow that to resolve this *** This bug has been marked as a duplicate of bug 13597 *** |