Bug 5782

Summary: Add warning when ordering a duplicate record from external source
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: AcquisitionsAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: PATCH-Sent (DO NOT USE) CC: chris, nengard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screen shot
Patch

Description Marcel de Rooy 2011-02-21 12:33:31 UTC
If you want to make an order from external source, but the external record has duplicates in your catalog, Koha now uses the existing record instead. Unfortunately, the user is not made aware of this fact.

IMHO Koha should warn the user and offer three choices: 1) take the existing record and order [current behavior], 2) use the new duplicate record and order [for some reason..], 3) go back to the basket without ordering [I already have the book!]

Check this behavior in current master by:
1) Choose a record in your catalog, possibly coming from an external Z3950 source. Otherwise add a record from an external source (Z3950 search).
2) Go to Acquisition, add new basket, add new order from external source. Select the same title (make sure it is really a duplicate: title, author, isbn, itemtype).
3) Save the order (add quantity).
4) Check the new line in your basket. Does it point to your old biblio? If so, you had a duplicate. But Koha did not tell you! 

Test new behavior of proposed patch:
1) Install patch. Repeat step 2 (add order from external source).
2) A new form should come up now. See screen shot. Offering you the three choices mentioned.
3) Test each one of these choices and check the biblio number of new order lines (hovering your mouse above the title of the order line).
Comment 1 Marcel de Rooy 2011-02-21 13:05:29 UTC
Created attachment 3187 [details]
Screen shot
Comment 2 Marcel de Rooy 2011-02-21 13:31:27 UTC
Created attachment 3188 [details] [review]
Patch
Comment 3 Nicole C. Engard 2011-02-21 16:59:11 UTC
Tested and it works great so I'm signing off. I'd ask that down the road someone look into making the error message look a bit cleaner (I don't know if we need all that help text on the page - seems like it could go in the manual and the in line help file.

Nicole
Comment 4 Chris Cormack 2011-02-21 19:47:18 UTC
Pushed, please test