Bug 5805

Summary: Changing Pickup library on already queued holds causes havoc on all holds below it
Product: Koha Reporter: Liz Rea <wizzyrea>
Component: Hold requestsAssignee: D Ruth Holloway <ruth>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: critical    
Priority: PATCH-Sent (DO NOT USE) CC: chris, gmcharlt, nengard, wizzyrea
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: patch

Description Liz Rea 2011-02-23 15:16:29 UTC
If you update the pickup library on any of the holds in a list, when there are items in transit, the hold above the intended hold in the queue changes to the
selected library, the hold you changed changes to some other (random?) library,
and every hold below the changed  hold is changed to the first library in the branches list.

We did not see this behavior on items with only new holds (no items in transit) or items with holds that were only "waiting".

Here is a screencast: http://screencast.com/t/fAcGYAcJ8ay
Comment 1 Nicole C. Engard 2011-02-25 13:40:12 UTC
Created attachment 3218 [details] [review]
patch
Comment 2 Chris Cormack 2011-02-26 07:48:48 UTC
Pushed, please test and mark resolved
Comment 3 Liz Rea 2011-03-02 18:12:44 UTC
tested, works as advertised.