Bug 6181

Summary: Remove CGI::scrolling_list from C4:Budgets
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: TemplatesAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, paul.poulain
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 766    
Attachments: Proposed Patch
Signed off Patch
proposed patch (passed QA)

Description Colin Campbell 2011-04-13 16:15:26 UTC
As noted in bug 766 3.2 imported a lot of new instances of CGI::scrolling_list into C4::Budgets. They should be fixed. Most of them are not used by any other code so should be cleaned out.
Comment 1 Colin Campbell 2011-04-13 16:39:03 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-05-25 13:42:57 UTC
Colin could you provide more info on how to properly test these changes?
Comment 3 Colin Campbell 2011-05-27 15:46:28 UTC
The only meaningful test is to ensure the fund selection box in order creation is working. As noted in the patch the dropdowns for sort1/sort2 do not appear to be activated in the standard version.
Comment 4 Chris Cormack 2011-06-04 10:00:28 UTC Comment hidden (obsolete)
Comment 5 Paul Poulain 2011-08-10 12:32:01 UTC
Created attachment 4933 [details] [review]
proposed patch (passed QA)

QA comment:
* after applying the patch, I made grep -R on the 3 removed sub GetBudgetPermDropbox, GetBudgetSortDropbox, GetBudgetPeriodsDropbox they don't appear anywhere anymore
* changes made to GetAuthvalueDropbox are also consistents
* I've tested the scripts modified by this patch (aqbugetperiod, addorderiso2709,...), no problem detected.

passed QA
Comment 6 Chris Cormack 2011-08-14 08:29:22 UTC
Pushed, please test well
Comment 7 Jared Camins-Esakov 2012-12-31 00:26:59 UTC
There have been no further reports of problems so I am marking this bug resolved.