Summary: | koha-remove should check the number of arguments it gets | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Packaging | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, jcamins, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 7924 | ||
Bug Blocks: | 6416, 4880 | ||
Attachments: |
A patch to the koha-remove script
Patch to bugs 6684 6997 4880 Patches to bugs 6684 6997 4880 6684 koha-remove should check the number of arguments it gets 6997 koha-remove leaves system in inconsistent state if there is an error 4880 koha-remove sometimes fails because user is logged intkoha-remove sometimes fails b Bug 6684: Fixes to koha-remove |
Description
Magnus Enger
2011-08-09 10:31:56 UTC
Created attachment 6320 [details] [review] A patch to the koha-remove script This is a patch to the koha-remove script in debian/scripts It: 1) Checks that the command line arguments are not blank 2) Checks that the instance being removed does in fact exist in some form Created attachment 6336 [details] [review] Patch to bugs 6684 6997 4880 Ignore the above patch, I think this one is better. I have attempted to address: 6684 koha-remove should check the number of arguments it gets 6997 koha-remove leaves system in inconsistent state if there is an error 4880 koha-remove sometimes fails because user is logged intkoha-remove sometimes fails because user is logged in I think it formatted correctly now too. This should be "Needs signoff", I think? Created attachment 9003 [details] [review] Patches to bugs 6684 6997 4880 6684 koha-remove should check the number of arguments it gets 6997 koha-remove leaves system in inconsistent state if there is an error 4880 koha-remove sometimes fails because user is logged intkoha-remove sometimes fails b Amended by chrisc@catalyst.net.nz Trying to resolve conflicts. Hi Simon, sorry about the long delay on this. The patch applied with a few conflicts, not sure I tidied them up all correctly can you take a look at it and check it looks ok please. Created attachment 9533 [details] [review] Bug 6684: Fixes to koha-remove Fixes bugs 6684 6997 4880: 6684 koha-remove should check the number of arguments it gets 6997 koha-remove leaves system in inconsistent state if there is an error 4880 koha-remove sometimes fails because user is logged in Amended by chrisc@catalyst.net.nz Trying to resolve conflicts. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on top of bug 7924. The signed off patch will not apply without 7924. QA comment : tiny patch, nothing specific to say about QA Patch pushed, Welcome Simon Story, you're the 182th committer ! Only just really noticed this now, but I have to say that I really appreciated the commenting added. Will be in 3.8.2 |