Bug 6960

Summary: staffaccess permission requires borrowers permission
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: PatronsAssignee: Kyle M Hall <kyle.m.hall>
Status: ASSIGNED --- QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: dcook, gmcharlt, katrin.fischer, srdjan, veron, wizzyrea
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Nicole C. Engard 2011-10-03 17:33:23 UTC
There are one of two solutions to this problem.  Right now you can't have staffaccess permission without borrowers permission, so one solution is to move staffaccess under borrowers to make it clear that it's dependent on that permission. 

The other solution is to make it so that you can have staffaccess without borrowers.
Comment 1 Srdjan Jankovic 2012-02-09 01:39:20 UTC
So which one is preferred?
Comment 2 Nicole C. Engard 2012-02-14 19:43:06 UTC
I think the first option - it makes sense that you need borrower permission to be able to set staff permissions.  So I say move the option for staffaccess up under borrowers so it's clear that you need borrowers permissions to access staff permissions.  

I'm up for other opinions of course.
Comment 3 Liz Rea 2012-04-03 15:31:11 UTC
Move the permission under borrowers, please. That makes good sense.
Comment 4 Marc VĂ©ron 2016-09-29 16:36:30 UTC
Still valid?
Comment 5 Katrin Fischer 2018-05-17 22:11:26 UTC
I am not sure about moving it into the borrowers permission:

staffaccess:
Allow staff members to modify permissions for other staff members

Could it make more sense to put it under permissions?
Comment 6 Katrin Fischer 2019-01-11 22:13:28 UTC
Moving it is not only a visual change, but will also change how this permission is stored in the db as it will move from top to second level. 

Also:
- People now having full borrowers will have to be changed to have all borrowers sub permissions but staffaccess.
- People now having staffaccess need to get the new sub permission. Also: userflags has to be updated.
Comment 7 David Cook 2022-11-01 23:58:48 UTC
I agree with Katrin. It's not feasible to turn "staffacess" into a subpermission of "borrowers".

In theory, the "staffaccess" line could be moved up and placed adjacent to the "borrowers" and "permissions" lines. However, that would probably require a re-jigging of the templating, since right now the permissions are in "bit" order. 

That re-jigging might be a good idea though, as there are other permissions that could potentially be grouped together functionally.
Comment 8 Katrin Fischer 2023-08-05 09:31:48 UTC
I suggest to just add a hint to the permission as an easy fix.
Comment 9 David Cook 2023-11-21 23:53:33 UTC
(In reply to Katrin Fischer from comment #8)
> I suggest to just add a hint to the permission as an easy fix.

Makes sense to me