Bug 6987

Summary: C4::Overdues::GetFine returns inconsistent
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: CirculationAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: gmcharlt, m.de.rooy, paul.poulain, sophie.meynieux
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed Patch
Signed-off patch

Description Colin Campbell 2011-10-07 12:07:53 UTC
The subroutine GetFine returns the amount of the fine owing but if that is none it returns undef. This results in warnings 'undefined variable $fine' in overdues causing concern for users seeing this report if the amount is 0 that should be returned rather than causing problems for calling code
Comment 1 Colin Campbell 2011-10-07 12:55:48 UTC Comment hidden (obsolete)
Comment 2 Sophie MEYNIEUX 2011-11-04 15:30:13 UTC
Created attachment 6206 [details] [review]
Signed-off patch

Warning on undef variable in string concatenation is removed
Comment 3 Marcel de Rooy 2011-12-07 13:45:32 UTC
QA: Did not actually test it, but this small change in code looks good. Marking as Passed QA.
Comment 4 Paul Poulain 2011-12-08 10:20:16 UTC
patch pushed, please test
Comment 5 Jared Camins-Esakov 2012-05-23 12:50:18 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.