Bug 7194

Summary: OPAC detail and recent comments pages require corrections for XHTML validity
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: minor    
Priority: P5 - low CC: chris, cnighswonger, jcamins, paul.poulain
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed fix
Fix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity

Description Owen Leonard 2011-11-08 16:43:10 UTC
- unescaped ampersands
- images without alt attributes
Comment 1 Owen Leonard 2011-11-08 16:48:33 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-12-12 09:05:59 UTC
Created attachment 6719 [details] [review]
Fix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity

- Adding html filter to subtitle output to correct unescaped ampersands
- Adding missing alt attributes to libravatar output
- Removing unecessary markup  from comments page

Bonus: Adding html_break filter to output of comments to preserve line breaks
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Ian Walls 2012-01-05 13:28:47 UTC
Adds alts, html escapement and a new html_break filter to various large text blobs.  Also removes a yui-b div.

Marking as Passed QA
Comment 4 Paul Poulain 2012-01-06 14:53:00 UTC
patch pushed, please test
Comment 5 Chris Nighswonger 2012-01-21 05:02:32 UTC
Patch does not apply cleanly to 3.4.x. Please rebase against 3.4.x and attach a new patch.
Comment 6 Paul Poulain 2012-02-15 16:03:04 UTC
I think it's not critical to fix this bug for 3.4 that is close to EOL. It's fixed in master though, marking RESO FIXED