Bug 7309

Summary: Add NORMARCslim2intranetDetail.xsl for detail view in intranet
Product: Koha Reporter: Magnus Enger <magnus>
Component: SearchingAssignee: Magnus Enger <magnus>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: enhancement    
Priority: PATCH-Sent (DO NOT USE) CC: katrin.fischer, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patch
[SIGNED-OFF] Bug 7309 - Add NORMARCslim2intranetDetail.xsl for detail view in intranet

Description Magnus Enger 2011-12-02 10:36:06 UTC
Currently, if you set marcflavour = NORMARC and XSLTDetailsDisplay to use XSLT, you get a nasty error, because there is no NORMARCslim2intranetDetail.xsl: 

Could not create file parser context for file "/home/magnus/kohanor32/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl": No such file or directory at /home/magnus/kohanor32/C4/XSLT.pm line 174
Comment 1 Magnus Enger 2011-12-02 16:38:05 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-12-03 09:03:41 UTC
Created attachment 6553 [details] [review]
[SIGNED-OFF] Bug 7309 - Add NORMARCslim2intranetDetail.xsl for detail view in intranet

Adds two files, to enable XSLT for the detail view in the intranet:
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl

To test:
- Set sysprefs: marcflavour = NORMARC and XSLTDetailsDisplay = "using XSLT stylesheet"
- Make sure OPACBaseURL is set correctly
- Check that detail display looks ok
- Check that automatic links for author, subjects etc work
- Check that the "Open in new window" link works as expected
- Empty the OPACBaseURL syspref and check that "Open in new window" does not display

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Great test plan, could reproduce problem and can confirm patch fixes it.
Comment 3 Paul Poulain 2011-12-14 17:19:36 UTC
QA comment: specific to normarc, won't break anything if there's a problem with this patch except norvegian setups. Add 2 files, OK


prove t/00-valid-xml.t 
t/00-valid-xml.t .. ok     
All tests successful.

passed QA

patch pushed, please test
Comment 4 Magnus Enger 2012-04-27 14:20:18 UTC
Works in 3.8