Bug 7341

Summary: Clicking cancel on system preferences search results causes error
Product: Koha Reporter: Liz Rea <wizzyrea>
Component: Staff interfaceAssignee: Paul Poulain <paul.poulain>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: trivial    
Priority: PATCH-Sent (DO NOT USE) CC: duncan, gmcharlt, magnus
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Fixed error when clicking cancel in search results for system preferences
Signed-off patch

Description Liz Rea 2011-12-08 20:45:41 UTC
Software error:

Template process failed: file error - /home/liz/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/HASH(0xa7d8af8).pref: not found at /home/liz/kohaclone/C4/Templates.pm line 125.
For help, please send mail to the webmaster (webmaster@koha-deb), giving this error message and the time and date of the error.

This happens when you click cancel on a system preferences result listing after a search.
Comment 1 Duncan 2011-12-22 01:43:51 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2011-12-30 13:42:02 UTC
Created attachment 6972 [details] [review]
Signed-off patch

Before the patch searching for a syspref, changing something and clicking "Cancel" produces the error message described in the bug report. 

After the patch, doing the same thing results in the form being reset to what it was before any changes were made to any of the fields.

Signing off!
Comment 3 Ian Walls 2012-01-05 13:23:35 UTC
Fixes issue.  The new behaviour is now to get a "leave or stay" confirmation (at least from Firefox).  If you're coming into this search from the Admin main page, there is an additional warning asking you to resend.  Not optimal, but vastly superior to a software error.

Marking Passed QA
Comment 4 Paul Poulain 2012-01-06 14:17:59 UTC
patch pushed, please test
Comment 5 Jared Camins-Esakov 2012-05-23 12:06:31 UTC
Included in 3.6 prior to 3.6.5.