Bug 7521

Summary: Cannot receive serials without full serials permissions
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: SerialsAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: normal    
Priority: P3 CC: jcamins, nengard, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: permissions
Bug 7521: Templates should use receive_serials permission
Bug 7521: Templates should use receive_serials permission

Description Katrin Fischer 2012-02-10 05:37:44 UTC
Created attachment 7553 [details]
permissions

Although there is a separate permission or receiving issues of serials, missing the general serials permission will not let you access the serials receive page.

To test:
1) Modify permissions of a staff user, uncheck "routing" or any other permission, so the general serials permission is unchecked. Also remove superlibrarian permission.
2) Try to add a subscription and receive a serial for it. You should not be able to access .../cgi-bin/koha/serials/serials-edit.pl...
Comment 1 Katrin Fischer 2012-02-10 06:37:45 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-02-10 06:41:05 UTC
*** Bug 7405 has been marked as a duplicate of this bug. ***
Comment 3 Katrin Fischer 2012-02-10 06:42:15 UTC
*** Bug 7273 has been marked as a duplicate of this bug. ***
Comment 4 Jared Camins-Esakov 2012-02-12 19:51:20 UTC
Created attachment 7595 [details] [review]
Bug 7521: Templates should use receive_serials permission

Corrects templates to use permission receive_serials.

Before patch:
1) Serial receive page (/cgi-bin/koha/serials/serials-edit.pl...)
can only be accessed with full serials permissions.
When one permission is missing, page can not be accessed.

2) Serial collection/Issue History page (/cgi-bin/koha/serials/serials-collection.pl...)
can only be accessed with full serials permissions.

After applying patch:
1) Serial receive page can only be accessed when user has receive_serials
permission.

2) Edit and serial receive links are hidden, when user doesn't have
serials_receive permission. Page is accessible with at least 1 serials
permission.

I will send a another patch to correct behaviour for the routing permission.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 5 Ian Walls 2012-02-16 17:17:05 UTC
Correctly implements permissions changes, and hides links to tasks that are not performable by the logged in user.  Marking as Passed QA.
Comment 6 Paul Poulain 2012-02-17 08:53:32 UTC
I also checked that having superlibrarian flag work fine