Summary: | Suggestion show page | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 5346 | ||
Bug Blocks: | 8152 | ||
Attachments: |
Bug 7577 Adds a display page for suggestions
Bug 7577 Adds a display page for suggestions [SIGNED-OFF] Bug 7577: Adds a display page for suggestions |
Description
Jonathan Druart
2012-02-22 14:35:48 UTC
Created attachment 7802 [details] [review] Bug 7577 Adds a display page for suggestions Proposed patch There are some HTML markup issues with the template for suggestion.pl: Because the validator doesn't like when you use a <label> without an input, there is an alternative for displaying information which isn't in a form: <span class="label">. Using that will give you the same visual style and keep the validator happy. I would probably make display of each of those lines conditional on the existence of the data: [% IF ( total ) %]<li> <span class="label">Total</span>[% total %] </li>[% END %] ...but others might disagree. I'm not sure when the absence of data is important data. There's also a problem with the conditional display of the page's structural markup. There is a superfluous section at the bottom of the page source: <div id="doc3" class="yui-t2"> <div id="bd"> <div id="yui-main"> <div class="yui-b"> Created attachment 7810 [details] [review] Bug 7577 Adds a display page for suggestions Hi Owen, Thank you for yours remarks. I think we want to display all information, even when empty. It seems this is the way it works in others koha parts. I perform yours others remarks. Created attachment 8125 [details] [review] [SIGNED-OFF] Bug 7577: Adds a display page for suggestions Signed-off-by: Owen Leonard <oleonard@myacpl.org> Largely a template change; the changes to suggestions.pl are only insofar as to add support for the 'show' op, and clean up some of the foreach statements. Marking Passed QA |