Summary: | Have book cover image script return single-pixel gif data | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kristina, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 7600: Return a single-pixel GIF when no local cover image exists
signed-off patch |
Description
Owen Leonard
2012-02-24 21:33:39 UTC
Created attachment 8068 [details] [review] Bug 7600: Return a single-pixel GIF when no local cover image exists Created attachment 8254 [details] [review] signed-off patch The test of the proposed patch was successful in that the 404 error message is not shown anymore (in Firefox 10 it could only be seen in the "Net" tab in Firebug after a reload of the page). The patch adds a tiny gif image and the placeholder "No cover image available" is not displayed. I saw that as a good sign to avoid too much information that doesn't really help the user. Falling back to a 1 pixel gif seems pretty safe, and it's well implemented here. This also opens the door for other default 'noimage' images down the road, should it ever come up. Passed QA. * local cover is a 3.8 ENH, so setting version accordingly * C4/Image.pm has 2 perlcritic failure before the patch, one after, good job ;-) |