Summary: | Software error while placing order | ||
---|---|---|---|
Product: | Koha | Reporter: | shahas <shahas.sss> |
Component: | Acquisitions | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P3 | CC: | chris, fridolin.somers, jcamins, jonathan.druart, paul.poulain, shahas.sss |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed patch
Bug 7921: Software error while placing order |
Description
shahas
2012-04-07 12:47:31 UTC
ACQ Framework should be used. But in actual version, the default framework is used instead and a message is displayed on acquisition pages. (In reply to comment #1) > ACQ Framework should be used. But in actual version, the default framework > is used instead and a message is displayed on acquisition pages. I mean, default framework is used if ACQ framework does not exist. I confirm there can be a software error when adding a new order from external source or import. The bug appeared when z3950NormalizeAuthor syspref is on. Created attachment 13137 [details] [review] Proposed patch The bug comes from a call at GetMarcFromKohaField without framework code arg. I added the possibility to call this method without framework code arg, in this case the default framework is used. Created attachment 13335 [details] [review] Bug 7921: Software error while placing order Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA Comment: Looks good. We cannot add a framework with a framework_code = 0. Not blocker: the modification in acqui/neworderempty.pl is useless. Marked as Passed QA. This patch has been pushed to master. Pushed to 3.8.x, will be in 3.8.7 Patch pushed to branch 3.10.x |