Summary: | Hidden field does not hide from plain MARC and normal views in staff | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric P626 <epietrocupo.hlhl> |
Component: | MARC Bibliographic data support | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | ASSIGNED --- | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, katrin.fischer, Laura.escamilla, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
Description
Eric P626
2012-06-28 15:48:08 UTC
In my testing it shows that hiding from the plain MARC view indeed does not work :( To test: - Edit a MARC framework - change 245$a to not display in OPAC and staff - Check the plain MARC view in OPAC and staff - Notice that the field still displays - Notice that it hides correctly from the labelled MARC views Confirmed, testing with 245$c this time. Normal view and labelled MARC view are ok, plain MARC view displays the field. (In reply to Katrin Fischer from comment #2) > Confirmed, testing with 245$c this time. > > Normal view and labelled MARC view are ok, plain MARC view displays the > field. I see it on both labelled MARC (catalogue/labeledMARCdetail.pl) and normal (catalogue/detail.pl) views. Tested with 245$h. labeledMARCdetail.pl: TITLE STATEMENT E Street shuffle : the glory days of Bruce Springsteen & the E Street Band / Clinton Heylin. this is 245$h detail.pl (in the h1.title): E Street shuffle : the glory days of Bruce Springsteen & the E Street Band / Clinton Heylin. this is 245$h MARC preview (from svc/records/preview): 245 1 0 _aE Street shuffle : _bthe glory days of Bruce Springsteen & the E Street Band / _cClinton Heylin. _hthis is 245$h Hidden in catalogue/MARCdetail.pl - OK Note that catalogue/ISBDdetail.pl also displays the field (C4::Biblio::GetISBDView only hides the fields for OPAC): 730 # OPAC hidden subfield 731 next 732 if ( ( $template eq 'opac' ) 733 && ( $tagslib->{$fieldvalue}->{$subfvalue}->{'hidden'} || 0 ) > 0 ); Thx Jonathan, I lost sight of this and it seems quite bad. I think most important would be to fix the OPAC views - people want to hide things from patrons, staff views could be second priority. (In reply to Katrin Fischer from comment #5) > I think most important would be to fix the OPAC views - people want to hide > things from patrons, staff views could be second priority. I only reproduce on the svc/records/preview script. Can you please re-check? (In reply to Katrin Fischer from comment #5) > I think most important would be to fix the OPAC views - people want to hide > things from patrons, staff views could be second priority. This is solved in the OPAC \o/ Setting In discussion until some more feedback is provided. OPAC is done on separate bugs and is already fixed in master. And svc/records/preview I think it shouldn't be filtered, as batch modifications should display all subfields to avoid unknowingly removing/changing unwanted fields/subfields. I've tested this again with 245$b, hidden in OPAC and staff interface:
OPAC
- Normal view: OK
- MARC view: OK
- MARC view (Plain): OK!
- IBSD view: OK
Staff interface
- Normal: VISIBLE
- MARC tab (labelled): OK
- ISBD: OK
- Plain MARC view (link on Normal): VISIBLE
> And svc/records/preview I think it shouldn't be filtered, as batch
> modifications should display all subfields to avoid unknowingly
> removing/changing unwanted fields/subfields.
If this is used for creating the plain MARC view in staff, I think we should filter it here and discuss batch modifications separately. I think as 'batch' inquires editing, we could use the editor flag there instead.
I am changing the bug description to reflect the current status. Also decreasing importance to normal.
Commenting to put this back on everyone's radar. We are still running into this issue. |